Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-36222: OCPBUGS-35898: capi/aws: bump provider for LB DNS lookup fix #8927

Merged
merged 3 commits into from
Nov 5, 2024
Merged

OCPBUGS-36222: OCPBUGS-35898: capi/aws: bump provider for LB DNS lookup fix #8927

merged 3 commits into from
Nov 5, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Aug 30, 2024 •
edited
Loading

Testing what happens if we skip the LB DNS name resolution check altogether.

Edit: The proposed fix has merged upstream kubernetes-sigs/cluster-api-provider-aws#5093

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Aug 30, 2024

/uncc @patrickdillon @sadasu

@r4f4 r4f4 mentioned this pull request Aug 30, 2024
Merged
5 tasks
@r4f4
Copy link
Contributor Author

r4f4 commented Sep 1, 2024

/retest

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 1, 2024

/test e2e-aws-ovn e2e-aws-ovn-edge-zones e2e-aws-ovn-fips e2e-aws-ovn-shared-vpc-custom-security-groups e2e-aws-ovn-single-node e2e-external-aws-ccm

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 2, 2024

/test artifacts-images

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 26, 2024

/retitle OCPBUGS-36222: OCPBUGS-35898: capi/aws: bump provider for LB DNS lookup fix

@openshift-ci openshift-ci bot changed the title WIP: Capa remove lb dns check OCPBUGS-36222: OCPBUGS-35898: capi/aws: bump provider for LB DNS lookup fix Oct 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 26, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-36222, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Testing what happens if we skip the LB DNS name resolution check altogether.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 26, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 26, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-36222, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 26, 2024

/cc @patrickdillon @sadasu

CC'ing back in as it's ready for review now.

@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-36222, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Testing what happens if we skip the LB DNS name resolution check altogether.

Edit: The proposed fix has merged upstream kubernetes-sigs/cluster-api-provider-aws#5093

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
OCPBUGS-36222: capi/aws: bump provider version to latest main
b05a593 
We need to bump capa to get a fix for the LB DNS name lookup issue.

Notable changes from `git log --oneline 3f3ce5610204..5b4f7c1ac`:
```
32ebcce58 🐛elbv2: wait for LB active state instead of resolving DNS name
7e0812f59 🌱 Bump CAPI to v1.8.4 (openshift#5061)
8f46a4d34 Allow to specify cidr block for default node nodeport ingress rule
```
@r4f4
capi/aws: update CRD after CAPA bump
33ea759
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 26, 2024

Update: dropped the capi bump to 1.8.4 as it's been already done by #9118

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 26, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack 0783224 link false /test e2e-azurestack
ci/prow/e2e-aws-ovn-single-node 0783224 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-edge-zones 0783224 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-azure-ovn-shared-vpc 0783224 link false /test e2e-azure-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

barbacbd
barbacbd reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cf09e38 and 2 for PR HEAD 0783224 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 00a96e5 into openshift:master Nov 5, 2024
31 of 36 checks passed
@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-36222: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36222 has been moved to the MODIFIED state.

In response to this:

Testing what happens if we skip the LB DNS name resolution check altogether.

Edit: The proposed fix has merged upstream kubernetes-sigs/cluster-api-provider-aws#5093

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4 r4f4 mentioned this pull request Nov 5, 2024
Merged
@r4f4 r4f4 mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@barbacbd barbacbd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r4f4 @openshift-ci-robot @patrickdillon @barbacbd @openshift-merge-robot