Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-41538: Remove bindings for XPN installs #8989

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

barbacbd
Copy link
Contributor

** During XPN installs bindings are created in the host project to the service account used to perform actions in the host project. These bindings are left over during the destruction process if they are not explicitly found and removed in the host project rather than the default (service) project.

** During XPN installs bindings are created in the host project to the service account used to perform
actions in the host project. These bindings are left over during the destruction process if they are not
explicitly found and removed in the host project rather than the default (service) project.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 10, 2024
@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-41538, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

** During XPN installs bindings are created in the host project to the service account used to perform actions in the host project. These bindings are left over during the destruction process if they are not explicitly found and removed in the host project rather than the default (service) project.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Contributor Author

/label platform/google

@openshift-ci openshift-ci bot requested a review from gpei September 10, 2024 16:33
@barbacbd
Copy link
Contributor Author

/cc @bfournie
/cc @patrickdillon

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-secureboot 03d46a5 link false /test e2e-gcp-secureboot

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@patrickdillon
Copy link
Contributor

/approve

@patrickdillon
Copy link
Contributor

/cherry-pick release-4.17

@openshift-cherrypick-robot

@patrickdillon: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0012dd0 into openshift:master Sep 17, 2024
21 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

@barbacbd: Jira Issue OCPBUGS-41538: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41538 has been moved to the MODIFIED state.

In response to this:

** During XPN installs bindings are created in the host project to the service account used to perform actions in the host project. These bindings are left over during the destruction process if they are not explicitly found and removed in the host project rather than the default (service) project.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@patrickdillon: new pull request created: #9024

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants