Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3702: Add api and api-int ips to bootstrap node #9022

Merged

Conversation

barbacbd
Copy link
Contributor

** The api and api-int addresses are coming from the capi gcp provider. The addresses must be added to the Load Balancer Config and to the ignition config for the bootstrap node.

** The api and api-int addresses are coming from the capi gcp provider. The addresses
must be added to the Load Balancer Config and to the ignition config for the bootstrap
node.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2024
@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request explicitly references no jira issue.

In response to this:

** The api and api-int addresses are coming from the capi gcp provider. The addresses must be added to the Load Balancer Config and to the ignition config for the bootstrap node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Contributor Author

/label platform/google

@barbacbd
Copy link
Contributor Author

/cc @bfournie
/cc @patrickdillon
/cc @sadasu

Copy link
Contributor

@sadasu sadasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the format of the API Server IP address in the Cluster Status? Could add sample output here?
Why do we need to do:

apiIPAddress := *gcpCluster.Status.Network.APIServerAddress
addressCut := apiIPAddress[strings.LastIndex(apiIPAddress, "/")+1:]

@barbacbd
Copy link
Contributor Author

What is the format of the API Server IP address in the Cluster Status? Could add sample output here? Why do we need to do:

apiIPAddress := *gcpCluster.Status.Network.APIServerAddress
addressCut := apiIPAddress[strings.LastIndex(apiIPAddress, "/")+1:]
WARNING api address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/global/addresses/bbarbach-gcp-oa-scc2d-apiserver 
WARNING api int address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/regions/us-east1/addresses/bbarbach-gcp-oa-scc2d-api-internal

@sadasu
Copy link
Contributor

sadasu commented Sep 26, 2024

What is the format of the API Server IP address in the Cluster Status? Could add sample output here? Why do we need to do:

apiIPAddress := *gcpCluster.Status.Network.APIServerAddress
addressCut := apiIPAddress[strings.LastIndex(apiIPAddress, "/")+1:]
WARNING api address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/global/addresses/bbarbach-gcp-oa-scc2d-apiserver 
WARNING api int address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/regions/us-east1/addresses/bbarbach-gcp-oa-scc2d-api-internal

We should be able to get to the actual IP address.

@barbacbd
Copy link
Contributor Author

barbacbd commented Oct 1, 2024

What is the format of the API Server IP address in the Cluster Status? Could add sample output here? Why do we need to do:

apiIPAddress := *gcpCluster.Status.Network.APIServerAddress
addressCut := apiIPAddress[strings.LastIndex(apiIPAddress, "/")+1:]
WARNING api address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/global/addresses/bbarbach-gcp-oa-scc2d-apiserver 
WARNING api int address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/regions/us-east1/addresses/bbarbach-gcp-oa-scc2d-api-internal

We should be able to get to the actual IP address.

@sadasu We do get the actual IP address. You asked what the output above was, so I provided that output but maybe I should have provided the other data too. If you look at the changes to the PR we then take that information above and query the API to get the IP Address from the compute address.

@sadasu
Copy link
Contributor

sadasu commented Oct 1, 2024

What is the format of the API Server IP address in the Cluster Status? Could add sample output here? Why do we need to do:

apiIPAddress := *gcpCluster.Status.Network.APIServerAddress
addressCut := apiIPAddress[strings.LastIndex(apiIPAddress, "/")+1:]
WARNING api address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/global/addresses/bbarbach-gcp-oa-scc2d-apiserver 
WARNING api int address: https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/regions/us-east1/addresses/bbarbach-gcp-oa-scc2d-api-internal

We should be able to get to the actual IP address.

@sadasu We do get the actual IP address. You asked what the output above was, so I provided that output but maybe I should have provided the other data too. If you look at the changes to the PR we then take that information above and query the API to get the IP Address from the compute address.

Thanks! That is neat.

@sadasu
Copy link
Contributor

sadasu commented Oct 1, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@sadasu
Copy link
Contributor

sadasu commented Oct 1, 2024

/retitle CORS-3702: Add api and api-int ips to bootstrap node

@openshift-ci openshift-ci bot changed the title no-jira: Add api and api-int ips to bootstrap node CORS-3702: Add api and api-int ips to bootstrap node Oct 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2024

@barbacbd: This pull request references CORS-3702 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

** The api and api-int addresses are coming from the capi gcp provider. The addresses must be added to the Load Balancer Config and to the ignition config for the bootstrap node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Contributor

bfournie commented Oct 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b4ccd77 into openshift:master Oct 2, 2024
22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202410020939.p0.gb4ccd77.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.18.0-202410020939.p0.gb4ccd77.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202410020939.p0.gb4ccd77.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202410020939.p0.gb4ccd77.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants