-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3702: Add api and api-int ips to bootstrap node #9022
CORS-3702: Add api and api-int ips to bootstrap node #9022
Conversation
** The api and api-int addresses are coming from the capi gcp provider. The addresses must be added to the Load Balancer Config and to the ignition config for the bootstrap node.
@barbacbd: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label platform/google |
/cc @bfournie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the format of the API Server IP address in the Cluster Status? Could add sample output here?
Why do we need to do:
apiIPAddress := *gcpCluster.Status.Network.APIServerAddress
addressCut := apiIPAddress[strings.LastIndex(apiIPAddress, "/")+1:]
|
We should be able to get to the actual IP address. |
@sadasu We do get the actual IP address. You asked what the output above was, so I provided that output but maybe I should have provided the other data too. If you look at the changes to the PR we then take that information above and query the API to get the IP Address from the compute address. |
Thanks! That is neat. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle CORS-3702: Add api and api-int ips to bootstrap node |
@barbacbd: This pull request references CORS-3702 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
@barbacbd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
** The api and api-int addresses are coming from the capi gcp provider. The addresses must be added to the Load Balancer Config and to the ignition config for the bootstrap node.