Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1809: Added vSphere multi disk support #9035

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Sep 18, 2024

SPLAT-1809

Changes

  • Enhance install-config.yaml to allow for creating of additional vSphere disks
  • Leverage post-provision hook to add disks to masters after they have been created

Prerequisites

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@vr4manta vr4manta force-pushed the vsphere_multi_disk branch 5 times, most recently from 50e2f21 to c6c9734 Compare September 23, 2024 17:22
@vr4manta vr4manta changed the title WIP: Added vSphere multi disk support SPLAT-1809: Added vSphere multi disk support Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2024

@vr4manta: This pull request references SPLAT-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

  • Enhance install-config.yaml to allow for creating of additional vSphere disks
  • Leverage post-provision hook to add disks to masters after they have been created

Prerequisites

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2024

@vr4manta: This pull request references SPLAT-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

SPLAT-1809

Changes

  • Enhance install-config.yaml to allow for creating of additional vSphere disks
  • Leverage post-provision hook to add disks to masters after they have been created

Prerequisites

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta force-pushed the vsphere_multi_disk branch 2 times, most recently from 51f5ffb to 07c8924 Compare September 24, 2024 11:10
@vr4manta
Copy link
Contributor Author

/test all

@vr4manta vr4manta force-pushed the vsphere_multi_disk branch 2 times, most recently from b28c8c5 to 3bd0546 Compare September 24, 2024 15:31
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2024
@vr4manta
Copy link
Contributor Author

/test all

Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-tests-nodejoiner ff07805 link true /test integration-tests-nodejoiner
ci/prow/golint 5fe7c01 link true /test golint
ci/prow/e2e-vsphere-ovn-techpreview 5fe7c01 link false /test e2e-vsphere-ovn-techpreview
ci/prow/okd-verify-codegen 5fe7c01 link true /test okd-verify-codegen
ci/prow/verify-codegen 5fe7c01 link true /test verify-codegen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants