Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-3516: Document correlated observability #9046

Merged
merged 1 commit into from
Nov 5, 2024
Merged

OSASINFRA-3516: Document correlated observability #9046

merged 1 commit into from
Nov 5, 2024

Conversation

pierreprinetti
Copy link
Member

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@pierreprinetti pierreprinetti changed the title Document correlated observability OSASINFRA-3516: Document correlated observability Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3516 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pierreprinetti pierreprinetti force-pushed the document_correlated_observability branch 2 times, most recently from 7151d53 to 036ff63 Compare September 26, 2024 09:36
pierreprinetti
pierreprinetti commented Oct 10, 2024
View reviewed changes
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Show resolved Hide resolved
MaysaMacedo
MaysaMacedo reviewed Oct 14, 2024
View reviewed changes
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
mandre
mandre reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is RHOSO a well understrood acronym? Perhaps we should explain it refers to RHOSP version 18 and above.

docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md
Make sure you have the Cluster Observability Operator installed in the
OpenShift cluster running the OpenStack control plane, as this is a requirement
for the OpenStack Telemetry Operator. Follow [these
directions](https://github.com/openstack-k8s-operators/architecture/blob/main/examples/dt/uni01alpha/control-plane.md#cluster-observability-operator)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would point to the osasinfra DT, but openstack-k8s-operators/architecture#418 hasn't merged yet.

@pierreprinetti pierreprinetti force-pushed the document_correlated_observability branch from a530183 to d7b2b88 Compare October 16, 2024 09:14
@pierreprinetti pierreprinetti marked this pull request as ready for review October 16, 2024 09:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@pierreprinetti pierreprinetti force-pushed the document_correlated_observability branch from d7b2b88 to b946306 Compare October 17, 2024 08:06
vyzigold
vyzigold reviewed Oct 17, 2024
View reviewed changes
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
@pierreprinetti pierreprinetti force-pushed the document_correlated_observability branch 2 times, most recently from e6543df to 04bc4c0 Compare October 18, 2024 12:46
eurijon
eurijon reviewed Oct 23, 2024
View reviewed changes
Copy link

@eurijon eurijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I just added some minor comments

docs/user/openstack/observability.md Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
@pierreprinetti pierreprinetti force-pushed the document_correlated_observability branch from 04bc4c0 to e8dffd0 Compare October 24, 2024 08:43
mandre
mandre reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, looks good to me otherwise.

elfiesmelfie
elfiesmelfie suggested changes Nov 4, 2024
View reviewed changes
docs/user/openstack/observability.md Outdated Show resolved Hide resolved
@pierreprinetti @mandre
Document OpenShift-on-OpenStack correlated observability
ecba6d2 
Add instructions how to query OpenShift and OpenStack metrics together.

Co-authored-by: Pierre Prinetti <[email protected]>
Co-authored-by: Martin André <[email protected]>
@pierreprinetti pierreprinetti force-pushed the document_correlated_observability branch from e8dffd0 to ecba6d2 Compare November 5, 2024 09:23
mandre
mandre reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@mandre
Copy link
Member

mandre commented Nov 5, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 781cbc1 into openshift:master Nov 5, 2024
8 of 9 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the document_correlated_observability branch November 5, 2024 12:38
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202411051638.p0.g781cbc1.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411051638.p0.g781cbc1.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202411051638.p0.g781cbc1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzigold vyzigold vyzigold left review comments

@eurijon eurijon eurijon left review comments

@mandre mandre mandre left review comments

@elfiesmelfie elfiesmelfie elfiesmelfie requested changes

@EmilienM EmilienM Awaiting requested review from EmilienM

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pierreprinetti @openshift-ci-robot @mandre @openshift-bot @eurijon @MaysaMacedo @elfiesmelfie @vyzigold