-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-6508: Update Control Plane replica validation for Single Node OpenShift #9048
Open
sadasu
wants to merge
1
commit into
openshift:master
Choose a base branch
from
sadasu:sadasu-6508
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,7 +121,7 @@ func ValidateInstallConfig(c *types.InstallConfig, usingAgentMethod bool) field. | |
} | ||
allErrs = append(allErrs, validatePlatform(&c.Platform, usingAgentMethod, field.NewPath("platform"), c.Networking, c)...) | ||
if c.ControlPlane != nil { | ||
allErrs = append(allErrs, validateControlPlane(&c.Platform, c.ControlPlane, field.NewPath("controlPlane"))...) | ||
allErrs = append(allErrs, validateControlPlane(&c.Platform, c.ControlPlane, c.IsSingleNodeOpenShift(), field.NewPath("controlPlane"))...) | ||
} else { | ||
allErrs = append(allErrs, field.Required(field.NewPath("controlPlane"), "controlPlane is required")) | ||
} | ||
|
@@ -596,13 +596,20 @@ func validateNetworkingClusterNetworkMTU(c *types.InstallConfig, fldPath *field. | |
return allErrs | ||
} | ||
|
||
func validateControlPlane(platform *types.Platform, pool *types.MachinePool, fldPath *field.Path) field.ErrorList { | ||
func validateControlPlane(platform *types.Platform, pool *types.MachinePool, isSingleNodeOpenShift bool, fldPath *field.Path) field.ErrorList { | ||
allErrs := field.ErrorList{} | ||
if pool.Name != types.MachinePoolControlPlaneRoleName { | ||
allErrs = append(allErrs, field.NotSupported(fldPath.Child("name"), pool.Name, []string{types.MachinePoolControlPlaneRoleName})) | ||
} | ||
if pool.Replicas != nil && *pool.Replicas == 0 { | ||
allErrs = append(allErrs, field.Invalid(fldPath.Child("replicas"), pool.Replicas, "number of control plane replicas must be positive")) | ||
if pool.Replicas != nil { | ||
switch { | ||
case *pool.Replicas == 0: | ||
allErrs = append(allErrs, field.Invalid(fldPath.Child("replicas"), pool.Replicas, "number of control plane replicas must be positive")) | ||
case *pool.Replicas == 1 && !supportedSingleNodePlatform(isSingleNodeOpenShift, platform): | ||
allErrs = append(allErrs, field.Invalid(fldPath.Child("replicas"), pool.Replicas, "Single Node OpenShift(SNO) not supported by this install method for this platform")) | ||
case *pool.Replicas != 3: | ||
Comment on lines
+604
to
+610
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: these validation functions can get pretty unreadable. I recommend extracting this into a separate function, say allErrs = append(allErrs, ValidateControlPlaneReplicaCount(platform, pool, fldPath)...)
allErrs = append(allErrs, ValidateMachinePool(platform, pool, fldPath)...) |
||
allErrs = append(allErrs, field.Invalid(fldPath.Child("replicas"), pool.Replicas, "number of control plane replicas must equal 3")) | ||
} | ||
} | ||
allErrs = append(allErrs, ValidateMachinePool(platform, pool, fldPath)...) | ||
return allErrs | ||
|
@@ -1345,3 +1352,17 @@ func validateReleaseArchitecture(controlPlanePool *types.MachinePool, computePoo | |
|
||
return allErrs | ||
} | ||
|
||
// supportedSingleNodePlatform indicates if the IPI Installer can be used to install SNO on | ||
// a platform. | ||
func supportedSingleNodePlatform(bootstrapInPlace bool, p *types.Platform) bool { | ||
if p.AWS != nil || p.GCP != nil || p.Azure != nil { | ||
// Single node OpenShift installations supported without `bootstrapInPlace` | ||
return true | ||
} | ||
if bootstrapInPlace && p.None != nil { | ||
// Single node OpenShift installations supported with `bootstrapInPlace` | ||
return true | ||
} | ||
return false | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs (from what I could find), the default is 1 replica but it does not specify a maximum number or a constraint of 3.
https://docs.openshift.com/container-platform/4.16/rest_api/machine_apis/machineset-machine-openshift-io-v1beta1.html
Are we sure that 3 is the constraint here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
This has nothing to do with what is valid in the MachineSet API (which is not actually used for control plane Machines) and everything to do with what topologies of OpenShift are supported.