Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira: POC for custom dns solution for AWS #9053

Closed
wants to merge 3 commits into from
Closed

no-jira: POC for custom dns solution for AWS #9053

wants to merge 3 commits into from

Conversation

barbacbd
Copy link
Contributor

** Extract the public and private load balancer IP addresses from AWS.

@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request explicitly references no jira issue.

In response to this:

** Extract the public and private load balancer IP addresses from AWS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2024
@barbacbd
Copy link
Contributor Author

/cc @sadasu
/cc @r4f4
/cc @patrickdillon

@barbacbd
Copy link
Contributor Author

/label platform/aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from barbacbd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from rwsu September 24, 2024 20:28
@barbacbd barbacbd requested a review from r4f4 September 25, 2024 13:57
@barbacbd
Copy link
Contributor Author

Here is an example of the debug output. Obviously some of this will be altered and removed but this is just a POC.

WARNING Found Security Group ID: sg-0aba8642353ff37ae
WARNING Found Security Group ID: sg-07c327072b684a41a
WARNING Found Security Group ID: sg-089a25c2401e9aae2
WARNING Found Security Group ID: sg-0d32407a4f15df576
DEBUG found public IP address 3.143.87.169 from ELB net/bbarbach-23022-b8s2m-ext/418f4d0be91ce215 
DEBUG found private IP address 10.0.56.166 from ELB net/bbarbach-23022-b8s2m-int/6d8f3c4326c19b07 
DEBUG found public IP address 18.218.172.45 from ELB net/bbarbach-23022-b8s2m-ext/418f4d0be91ce215 
DEBUG found private IP address 10.0.69.81 from ELB net/bbarbach-23022-b8s2m-int/6d8f3c4326c19b07 
DEBUG found public IP address 3.14.102.136 from ELB net/bbarbach-23022-b8s2m-ext/418f4d0be91ce215 
DEBUG found private IP address 10.0.24.23 from ELB net/bbarbach-23022-b8s2m-int/6d8f3c4326c19b07 
WARNING public load balancer addresses: [3.143.87.169 18.218.172.45 3.14.102.136] 
WARNING private load balancer addresses: [10.0.56.166 10.0.69.81 10.0.24.23]

@barbacbd
no-jira: POC for custom dns solution for AWS
e46eedc 
** Extract the public and private load balancer IP addresses from AWS.
@barbacbd
no-jira: Add api and api-int ips to bootstrap node
4b7a5d9 
** The api and api-int addresses are coming from the capi gcp provider. The addresses
must be added to the Load Balancer Config and to the ignition config for the bootstrap
node.
@barbacbd
** Create ignition bucket for AWS bootstrap process
8a8d9cf 
** Fill the bucket with ignition data
** Update the ignition data with the load balancer ip addresses in the lb config

** Missing: Deletion of Bucket in DestroyBootstrap process
** Missing: CustomDNS Marker for AWS. This would make it tech preview
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous 8a8d9cf link false /test e2e-aws-ovn-heterogeneous
ci/prow/e2e-aws-ovn-imdsv2 8a8d9cf link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-gcp-ovn-xpn 8a8d9cf link false /test e2e-gcp-ovn-xpn
ci/prow/gofmt 8a8d9cf link true /test gofmt
ci/prow/golint 8a8d9cf link true /test golint
ci/prow/altinfra-e2e-aws-ovn 8a8d9cf link false /test altinfra-e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 8a8d9cf link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-gcp-secureboot 8a8d9cf link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn 8a8d9cf link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups 8a8d9cf link false /test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/e2e-aws-ovn-edge-zones 8a8d9cf link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-single-node 8a8d9cf link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-fips 8a8d9cf link false /test e2e-aws-ovn-fips
ci/prow/integration-tests-nodejoiner 8a8d9cf link true /test integration-tests-nodejoiner

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@barbacbd barbacbd closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

@rwsu rwsu Awaiting requested review from rwsu

@r4f4 r4f4 Awaiting requested review from r4f4

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. platform/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barbacbd @openshift-ci-robot @openshift-merge-robot @r4f4