Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.12] Fixes for retry errors #539

Open
wants to merge 5 commits into
base: release-4.12
Choose a base branch
from
Open

[4.12] Fixes for retry errors #539

wants to merge 5 commits into from

Conversation

mkowalski
Copy link

Contains the following to fix issues with NNCP retries

qinqon and others added 2 commits October 16, 2024 11:28
@qinqon @mkowalski
handler: Retry nncp status updated on error (nmstate#1269)
5bfbcd1 
At node reboot the NNCP get re-apply but nmstate-webhook may not be
ready so it fails, this change add a retry on error at nncp status
update to prevent this. Not that Reconcile cycle is not call since this
is done at a "defer" call.

Signed-off-by: Enrique Llorente <[email protected]>
@mkowalski
handler: retry NodeCount change on error (nmstate#1271)
d02cf85 
Signed-off-by: Mat Kowalski <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign cybertron for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski
Copy link
Author

/test e2e-handler-ovn-ipv4
/test e2e-handler-sdn-ipv4

error: timed out waiting for the condition on clusteroperators/image-registry

@mkowalski
Copy link
Author

/test e2e-handler-sdn-ipv4
/test images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 18, 2024

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-ovn-ipv4 a567b14 link false /test e2e-operator-ovn-ipv4
ci/prow/security a567b14 link false /test security
ci/prow/e2e-handler-ovn-ipv4 a567b14 link false /test e2e-handler-ovn-ipv4
ci/prow/e2e-handler-sdn-ipv4 a567b14 link true /test e2e-handler-sdn-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkowalski
Copy link
Author

/test images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@RamLavi RamLavi Awaiting requested review from RamLavi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkowalski @qinqon