-
Notifications
You must be signed in to change notification settings - Fork 125
WIP: STOR-2534: UPSTREAM: 135069: Update group snapshot tests to v1beta2 #2508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Copy VolumeGroupSnapshot v1beta2 CRDs from the external-snapshotter and disable v1beta1 API in them - we can't run the conversion webhook in e2e tests easily. Update e2e tests to use v1beta2.
|
@jsafrane: This pull request references STOR-2534 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jsafrane: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is only a part of the cherry-pick to update the external snapshotter to get v1beta2 group snapshot support.
|
@jsafrane: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jsafrane: This PR was included in a payload test run from openshift/cluster-csi-snapshot-controller-operator#252
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/97c92ec0-bbe3-11f0-860c-bb4a5945e9fe-0 |
Update e2e tests to use v1beta2 volume group snapshot API.