Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certgraphanalysis: add more locations for CA locations #1822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

certgraphanalysis: add more locations for CA locations #1822

wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Oct 8, 2024

CAs can be stored in a variety of keys. This commits adds more
common used configmap key names for CAs.

Tested in openshift/origin#29170

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs vrutkovs force-pushed the cert-inspection-configmap-keys branch from 96bb975 to f5af7ef Compare October 8, 2024 17:17
@vrutkovs
certgraphanalysis: add more locations for CA locations
cbe9e01 
  CAs can be stored in a variety of keys. This commits adds more
  common used configmap key names for CAs
@vrutkovs vrutkovs force-pushed the cert-inspection-configmap-keys branch from f5af7ef to cbe9e01 Compare October 9, 2024 06:47
@vrutkovs vrutkovs marked this pull request as ready for review October 9, 2024 13:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dinhxuanvu
dinhxuanvu approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu, vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@bertinatto bertinatto Awaiting requested review from bertinatto

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@dinhxuanvu dinhxuanvu

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrutkovs @dinhxuanvu