-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates/common/_base/units: disable Zincati service #1919
templates/common/_base/units: disable Zincati service #1919
Conversation
/retest |
3 similar comments
/retest |
/retest |
/retest |
c51098f
to
7a950e0
Compare
/lgtm |
We should be able to disable the service entirely once coreos/fedora-coreos-tracker#392 / systemd/systemd#15205 is fixed |
I don't think we need to block on that, see |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Oh right, let's do it that way :) |
7a950e0
to
2ec7291
Compare
Zincati is the update agent used on standalone Fedora CoreOS installations; it is not used on OKD clusters. Zincati is not shipped in RHEL CoreOS. This adds a condition to zincati.service which it can't fullfil, so that Fedora CoreOS nodes will not run it.
2ec7291
to
f0d01bf
Compare
/hold cancel |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, LorbusChris, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
This disables Zincati updates on FCOS nodes - no-op on RHCOS.