Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'eus' channels in non-prod #2197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use 'eus' channels in non-prod #2197

wants to merge 1 commit into from

Conversation

jewzaam
Copy link
Member

@jewzaam jewzaam commented Aug 20, 2024 •
edited
Loading

What type of PR is this?

feature

What this PR does / why we need it?

use eus channels for 4.1{2,4,6,8}

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/SDCICD-1365

Special notes for your reviewer:

Changes to CS, MUO, and CIS also required. See linked user story.

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
- key: api.openshift.com/fedramp
  operator: NotIn
  values: ["true"]

@openshift-ci openshift-ci bot requested review from maorfr and NautiluX August 20, 2024 17:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@jewzaam
Copy link
Member Author

jewzaam commented Aug 20, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@fahlmant
Copy link
Contributor

Should FedRAMP be excluded?

@jewzaam
Use 'eus' channels in non-prod
04b5d3d 
https://issues.redhat.com/browse/SDCICD-1365

eus can be used in non-FedRAMP
for this update eus is only for non-production
and limited to 4.12, 4.14, 4.16, 4.18
@jewzaam
Copy link
Member Author

jewzaam commented Aug 21, 2024

Should FedRAMP be excluded?

yea, updated and included 4.18 since it already exists in mcc
note this means 3x SSS for each even minor.. ugg

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@jewzaam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, jewzaam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustman9000,jewzaam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maorfr maorfr Awaiting requested review from maorfr

@NautiluX NautiluX Awaiting requested review from NautiluX

Assignees

@dustman9000 dustman9000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jewzaam @fahlmant @dustman9000