ingress access logging toggle added

[alvlkov]

What type of PR is this?

feature

What this PR does / Why we need it?

This script provides a toggle for enabling/disabling ingress access logging within the default ingress

Which Jira/Github issue(s) does this PR fix?

_Resolves #OSD-23991

Special notes for your reviewer

Validated within stage Classic ROSA
Verified logs container is created/removed when toggle is set accordingly.

Pre-checks (if applicable)

• Validated the changes in a cluster
• Included documentation changes with PR

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alvlkov
Once this PR has been reviewed and has the lgtm label, please assign mitalibhalla for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[typeid]

@alvlkov What is the process on the MCS side to ensure you revert the ingress access logging after a time period? Adding ingress access logging can result in additional resource usage, we want to ensure this is something that is disabled again after analysis is done.

[alvlkov]

Removed httpLogFormat from toggle response and fixed ACCESS_LOGGING variable reference

[alvlkov]

@alvlkov What is the process on the MCS side to ensure you revert the ingress access logging after a time period? Adding ingress access logging can result in additional resource usage, we want to ensure this is something that is disabled again after analysis is done.

AFAIK there is no specific process to ensure this.

[alvlkov]

/retest

[openshift-ci]

@alvlkov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	b1c4167	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[typeid]

AFAIK there is no specific process to ensure this.

Can we ensure that's the case?

[alvlkov]

@alvlkov What is the process on the MCS side to ensure you revert the ingress access logging after a time period? Adding ingress access logging can result in additional resource usage, we want to ensure this is something that is disabled again after analysis is done.

Can we ensure that's the case?

We are documenting all MCS/CEE scripts here. This specific script, once approved/merged, will be added to the mentioned doc. Additionally, it will be marked as CRU-only script. These scripts impact clusters and must be executed by a CRU (Critical Response Unit) member. We can further add additional note explicitly requiring to toggle off the access logging once CRU activity is finished.

Thanks
Regards

[typeid]

LGTM for the code. Pending compliance review for merge https://issues.redhat.com/browse/HCMSEC-611.
Please ensure we document removal of the toggle in the CRU flow.

/lgtm

[typeid]

/hold for compliance review https://issues.redhat.com/browse/HCMSEC-611.