Boilerplate: Update to 851cc4a567773fdfa7c879f2f1f2bd97f6981d43 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventions: - openshift/golang-osd-operator: Update --- openshift/boilerplate@4bf1a59...851cc4a commit: b8471722f97446ecb928f969d4452a9166b55fad author: Michael Shen Fix bugs preventing registry from running in fips mode registry.redhat.io/openshift4/ose-operator-registry:v4.12 is the OCP released image that has more guarantees about its release process and ubi-micro needs OpenSSL to be available in order to run in fips mode. Signed-off-by: Michael Shen <[email protected]> commit: e6dd946dc128b4c0a2354bb0221e60c713d29d35 author: Michael Shen Update after shift between rocket and security Signed-off-by: Michael Shen <[email protected]> commit: e54dfc24bf74099164f165a01c756f188224bc50 author: Ritu Mundhe dockerfile template fix commit: 6699b052ab9e59f909b8424b538d77be19ef100e author: Michael Shen Allow generation of embedded ObjectMeta in CRDs This will allow for using metav1.ObjectMeta's in nested fields. Without this option, the generated metadata field is non-functional as described in kubernetes-sigs/controller-tools#557. Signed-off-by: Michael Shen <[email protected]> Co-authored-by: Alice Hubenko <[email protected]> commit: cac1395fbae95d2dc43aeeec649dc46c04d065c4 author: Bo Meng update owners commit: 4c6d460e088fc7520d58cfeb2e5f457228b6ec13 author: Ritu Mundhe fixed hardcoded operator namein osde2e convention template commit: 56ec373e5d204115567d6a399e8cbfcdb71669cb author: Ryan Williams Replace addon with operator name for osde2e boilerplate This commit modifies the following: * Rename the junit output filename to include operator name * Update readme to remove the word "addon" commit: a000622561d57cefe749978b6505be030f3114bb author: Ritu Mundhe renamed test tags from "integration" to "osde2e" for specificity commit: bbb667c6d0ad14399c2e572acab68dd01ffa3f18 author: Dustin Row Exclude build/Dockerfile* from initial git status check commit: 7a16980d213b68b1a982ae3a710a5cee4b983491 author: Ritu Mundhe fix: escaped quote in template commit: ba40cfc5f02b30b6f9c4d1f420c14da7edd8a6c3 author: Ritu Mundhe osde2e dockerfile contains building ginkgo binary (#284) * osde2e dockerfile contains building ginkgo binary * Update ubi version Co-authored-by: Michael Shen <[email protected]> * Update go base image version Co-authored-by: Michael Shen <[email protected]> --------- Co-authored-by: Michael Shen <[email protected]> commit: 023d6fc8e9714428c149c7c1343e24b53449f4bd author: Ritu Mundhe reverting docker registry credentials for test-harness for app-interface commit: 50a4abf7890faa6bdbda0faa03cde25b5ba64be0 author: Ritu Mundhe updating docker registry credentials for test-harness for ci-operator commit: b2e3e1b90c2e5a60020cba909d2112b76021f201 author: Diego Santamaria Swap sed command delimiter I believe this will explode because $TEST_IMAGE contains /s. I would use some other delimiter for that sed command -- one that can't appear in a URI -- e.g.: Co-authored-by: Eric Fried <[email protected]> Remove project.mk commit: 7adb0b88cea0e8527b4d32ddeb9c5425e83aa7a3 author: Diego Santamaria Swap sed command delimiter I believe this will explode because $TEST_IMAGE contains /s. I would use some other delimiter for that sed command -- one that can't appear in a URI -- e.g.: Co-authored-by: Eric Fried <[email protected]> commit: 19ae2a423b085b1ae0b650374570da1784a8daa3 author: Diego Santamaria Add acceptance Test convention commit: f9e6c350556d9d5845babbb46686639a01945d03 author: Diego Santamaria Initial Commit for PD boiletPlate
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 13.78% 13.78%
=======================================
Files 14 14
Lines 1139 1139
=======================================
Hits 157 157
Misses 969 969
Partials 13 13 |
cblecker
deleted the
boilerplate-update--851cc4a567773fdfa7c879f2f1f2bd97f6981d43
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conventions:
openshift/boilerplate@4bf1a59...851cc4a
commit: b8471722f97446ecb928f969d4452a9166b55fad
author: Michael Shen
Fix bugs preventing registry from running in fips mode
registry.redhat.io/openshift4/ose-operator-registry:v4.12 is the OCP released image that has more guarantees about its release process and ubi-micro needs OpenSSL to be available in order to run in fips mode.
Signed-off-by: Michael Shen [email protected]
commit: e6dd946dc128b4c0a2354bb0221e60c713d29d35
author: Michael Shen
Update after shift between rocket and security
Signed-off-by: Michael Shen [email protected]
commit: e54dfc24bf74099164f165a01c756f188224bc50
author: Ritu Mundhe
dockerfile template fix
commit: 6699b052ab9e59f909b8424b538d77be19ef100e
author: Michael Shen
Allow generation of embedded ObjectMeta in CRDs
This will allow for using metav1.ObjectMeta's in nested fields. Without this option, the generated metadata field is non-functional as described in kubernetes-sigs/controller-tools#557.
Signed-off-by: Michael Shen [email protected]
Co-authored-by: Alice Hubenko [email protected]
commit: cac1395fbae95d2dc43aeeec649dc46c04d065c4
author: Bo Meng
update owners
commit: 4c6d460e088fc7520d58cfeb2e5f457228b6ec13
author: Ritu Mundhe
fixed hardcoded operator namein osde2e convention template
commit: 56ec373e5d204115567d6a399e8cbfcdb71669cb
author: Ryan Williams
Replace addon with operator name for osde2e boilerplate
This commit modifies the following:
commit: a000622561d57cefe749978b6505be030f3114bb
author: Ritu Mundhe
renamed test tags from "integration" to "osde2e" for specificity
commit: bbb667c6d0ad14399c2e572acab68dd01ffa3f18
author: Dustin Row
Exclude build/Dockerfile* from initial git status check
commit: 7a16980d213b68b1a982ae3a710a5cee4b983491
author: Ritu Mundhe
fix: escaped quote in template
commit: ba40cfc5f02b30b6f9c4d1f420c14da7edd8a6c3
author: Ritu Mundhe
osde2e dockerfile contains building ginkgo binary (#284)
osde2e dockerfile contains building ginkgo binary
Update ubi version
Co-authored-by: Michael Shen [email protected]
Co-authored-by: Michael Shen [email protected]
Co-authored-by: Michael Shen [email protected]
commit: 023d6fc8e9714428c149c7c1343e24b53449f4bd
author: Ritu Mundhe
reverting docker registry credentials for test-harness for app-interface
commit: 50a4abf7890faa6bdbda0faa03cde25b5ba64be0
author: Ritu Mundhe
updating docker registry credentials for test-harness for ci-operator
commit: b2e3e1b90c2e5a60020cba909d2112b76021f201
author: Diego Santamaria
Swap sed command delimiter
I believe this will explode because $TEST_IMAGE contains /s. I would use some other delimiter for that sed command -- one that can't appear in a URI -- e.g.:
Co-authored-by: Eric Fried [email protected]
Remove project.mk
commit: 7adb0b88cea0e8527b4d32ddeb9c5425e83aa7a3
author: Diego Santamaria
Swap sed command delimiter
I believe this will explode because $TEST_IMAGE contains /s. I would use some other delimiter for that sed command -- one that can't appear in a URI -- e.g.:
Co-authored-by: Eric Fried [email protected]
commit: 19ae2a423b085b1ae0b650374570da1784a8daa3
author: Diego Santamaria
Add acceptance Test convention
commit: f9e6c350556d9d5845babbb46686639a01945d03
author: Diego Santamaria
Initial Commit for PD boiletPlate