Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-admin CRD compatibility update for 130 #1605

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mpryc
Copy link
Contributor

@mpryc mpryc commented Dec 10, 2024

Small CRD updates to make the following PR passing:
migtools/oadp-non-admin#130

Why the changes were made

CRD updates for the non-admin PR

How to test the changes made

$ make update-non-admin-manifests

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@mpryc
Copy link
Contributor Author

mpryc commented Dec 10, 2024

/retest ci/prow/images

Copy link

openshift-ci bot commented Dec 10, 2024

@mpryc: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test 4.14-ci-index
/test 4.14-e2e-test-aws
/test 4.14-e2e-test-kubevirt-aws
/test 4.14-images
/test 4.15-ci-index
/test 4.15-e2e-test-aws
/test 4.15-e2e-test-kubevirt-aws
/test 4.15-images
/test 4.16-ci-index
/test 4.16-e2e-test-aws
/test 4.16-e2e-test-kubevirt-aws
/test 4.16-images
/test 4.17-ci-index
/test 4.17-e2e-test-aws
/test 4.17-e2e-test-kubevirt-aws
/test 4.17-images
/test 4.18-dev-preview-ci-index
/test 4.18-dev-preview-images
/test images
/test unit-test

The following commands are available to trigger optional jobs:

/test 4.18-dev-preview-e2e-test-aws

Use /test all to run all jobs.

In response to this:

/retest ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpryc
Copy link
Contributor Author

mpryc commented Dec 10, 2024

/test ci/prow/images

Copy link

openshift-ci bot commented Dec 10, 2024

@mpryc: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 4.14-ci-index
/test 4.14-e2e-test-aws
/test 4.14-e2e-test-kubevirt-aws
/test 4.14-images
/test 4.15-ci-index
/test 4.15-e2e-test-aws
/test 4.15-e2e-test-kubevirt-aws
/test 4.15-images
/test 4.16-ci-index
/test 4.16-e2e-test-aws
/test 4.16-e2e-test-kubevirt-aws
/test 4.16-images
/test 4.17-ci-index
/test 4.17-e2e-test-aws
/test 4.17-e2e-test-kubevirt-aws
/test 4.17-images
/test 4.18-dev-preview-ci-index
/test 4.18-dev-preview-images
/test images
/test unit-test

The following commands are available to trigger optional jobs:

/test 4.18-dev-preview-e2e-test-aws

Use /test all to run all jobs.

In response to this:

/test ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpryc
Copy link
Contributor Author

mpryc commented Dec 10, 2024

/test images

Small CRD updates to make the following PR passing:
  migtools/oadp-non-admin#130

Signed-off-by: Michal Pryc <[email protected]>
Copy link

openshift-ci bot commented Dec 10, 2024

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shubham-pampattiwar
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, mpryc, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mateusoliveira43,mpryc,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c7dc47e into openshift:master Dec 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants