Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLID-226: Add analysis of OCPSTRAT-1515 in its current state #926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sherine-k
Copy link
Contributor

@sherine-k sherine-k commented Sep 16, 2024

This PR contains no code.

This PR only contains the analysis done for OCPSTRATS-1515 in the light of the conversation with the Operator Framework team.

@lmzuccarelli, @aguidirh please review.

TODO:

  • Decide whether to use a Dockerfile to build the final image or to use the existing logic from v1 (add an extra layer for /configs, and white-out the old one using go-containerregistry)
  • Decide what to do about cache (cc @joelanford): should we change the image's CMD to remove the --cache-dir?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2024

@sherine-k: This pull request references CLID-226 which is a valid jira issue.

In response to this:

This PR contains no code.

This PR only contains the analysis done so far for OCPSTRATS-1515 in order to close the spike CLID-226 while we wait for further instructions from @tlwu2013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2024

@sherine-k: This pull request references CLID-226 which is a valid jira issue.

In response to this:

This PR contains no code.

This PR only contains the analysis done so far for OCPSTRATS-1515 in order to close the spike CLID-226 while we wait for further instructions from @tlwu2013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@sherine-k sherine-k closed this Sep 16, 2024
@sherine-k sherine-k reopened this Sep 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 17, 2024

@sherine-k: This pull request references CLID-226 which is a valid jira issue.

In response to this:

This PR contains no code.

This PR only contains the analysis done so far for OCPSTRATS-1515 in order to close the spike CLID-226 while we wait for further instructions from @tlwu2013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 20, 2024

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2024

@sherine-k: This pull request references CLID-226 which is a valid jira issue.

In response to this:

This PR contains no code.

This PR only contains the analysis done for OCPSTRATS-1515 in the light of the conversation with the Operator Framework team.

@lmzuccarelli, @aguidirh please review.

TODO:

  • Decide whether to use a Dockerfile to build the final image or to use the existing logic from v1 (add an extra layer for /configs, and white-out the old one using go-containerregistry)
  • Decide what to do about cache (cc @joelanford): should we change the image's CMD to remove the --cache-dir?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants