Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: Use cri-o module from Fedora #249

Merged
merged 1 commit into from
Jun 13, 2022
Merged

manifest: Use cri-o module from Fedora #249

merged 1 commit into from
Jun 13, 2022

Conversation

LorbusChris
Copy link
Member

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2021
@LorbusChris
Copy link
Member Author

It looks like cri-o is still at version 1.19 in both f34 and f35 modular repos. This can probably wait until we've rebased to f35, but it'd be great if we could start consuming cri-o from Fedora modular repos after that.

@vrutkovs
Copy link
Member

We're already using upstream repos for crio, what's the benefit of waiting more time for it to be packaged as a module?

@haircommander
Copy link
Member

It looks like cri-o is still at version 1.19 in both f34 and f35 modular repos

I've got 1.21 and 1.22 in testing right now https://bodhi.fedoraproject.org/users/haircommander if folks wanna go and give it karma :)

@jlebon
Copy link
Member

jlebon commented Nov 15, 2021

We're already using upstream repos for crio, what's the benefit of waiting more time for it to be packaged as a module?

Indeed, that's up to OKD to decide. I can say at least that doing so aligns better with coreos/fedora-coreos-tracker#767. I think we should add CI coverage for the Fedora modules in FCOS and if OKD uses the modules too, then CI could test it by simply running OKD node tests too, which I think increase the value a lot. Of course, this is all also related to #210.

@LorbusChris
Copy link
Member Author

/retest

1 similar comment
@haircommander
Copy link
Member

/retest

@LorbusChris
Copy link
Member Author

Build failure due to https://status.quay.io/incidents/rm3k6b5nby8m

@LorbusChris
Copy link
Member Author

/retest

2 similar comments
@LorbusChris
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member Author

/retest

@haircommander
Copy link
Member

haircommander commented Dec 22, 2021 •
edited
Loading

I am not sure why it takes so long, but I've finally seen 1.22 builds in bodhi for f34 https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2021-ee666025b5 once that makes it through, I think this will work?

@LorbusChris
Copy link
Member Author

Ah yeah, thanks I forgot we're still on F34 🤦‍♂️

While you're at this, any plans to do 1.23 builds soon? 😇

@haircommander
Copy link
Member

I am actively trying to get the module build to work! since it requires go 1.17 there may be a delay while fedora get it. the dist-git seems to indicate it's on 1.16 but I saw an article saying it'll make f35 so idk)

@LorbusChris
Copy link
Member Author

It looks like Go 1.17 has unfortunately been deferred to F36 :(
https://pagure.io/fedora-docs/release-notes/issue/713#comment-748924

@LorbusChris
Copy link
Member Author

/retest

@LorbusChris LorbusChris force-pushed the crio-module branch 2 times, most recently from 014aa65 to 8adf2a6 Compare December 24, 2021 09:59
@LorbusChris
Copy link
Member Author

OK, the module seems to be available now, but there's a new problem:

error: Problems appeared for module enable request:
  - Modular dependency problem: Problem: conflicting requests
  - nothing provides module(platform:f34) needed by module cri-o:1.22:3420211203192929:058368ca.x86_64

@jlebon any idea?

@jlebon
Copy link
Member

jlebon commented Jan 4, 2022

OK, the module seems to be available now, but there's a new problem:

error: Problems appeared for module enable request:
  - Modular dependency problem: Problem: conflicting requests
  - nothing provides module(platform:f34) needed by module cri-o:1.22:3420211203192929:058368ca.x86_64

@jlebon any idea?

Hmm not sure offhand, I'd have to dig in and try to reproduce it on the roughly equivalent FCOS 34 version. Usually, this works by libdnf looking at the base-module Provides, which is clearly present in f34.

@LorbusChris LorbusChris mentioned this pull request Jan 5, 2022
Merged
@LorbusChris
Copy link
Member Author

LorbusChris commented Jan 6, 2022 •
edited
Loading

we'll have to wait with this until there's a cri-o 1.23(++) module is available, which won't be the case before F36
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2022
@LorbusChris
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@LorbusChris: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/remove-lifecycle stale
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2022
@LorbusChris
Copy link
Member Author

/retest-required

@LorbusChris LorbusChris force-pushed the crio-module branch 2 times, most recently from bcd41d4 to 97ce794 Compare June 8, 2022 09:39
@vrutkovs
Copy link
Member

vrutkovs commented Jun 8, 2022

I'm a bit concerned about fixes taking more time to land in Fedora (due to Bodhi), but I think we'll take it.

However lets move "bump to F36" in a separate PR as its quite a big change

@LorbusChris
Copy link
Member Author

/retest-required

1 similar comment
@LorbusChris
Copy link
Member Author

/retest-required

@LorbusChris LorbusChris changed the title manifest: Use cri-o module from Fedora Switch to Fedora 36 and the cri-o 1.24 module Jun 8, 2022
@LorbusChris
Copy link
Member Author

/retitle manifest: Use cri-o module from Fedora
/hold

@openshift-ci openshift-ci bot changed the title Switch to Fedora 36 and the cri-o 1.24 module manifest: Use cri-o module from Fedora Jun 8, 2022
@LorbusChris
Copy link
Member Author

/test e2e-aws

@LorbusChris
Copy link
Member Author

/test e2e-aws

@vrutkovs
Copy link
Member

/retest

1 similar comment
@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022 •
edited
Loading

@LorbusChris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade 8adf2a6 link true /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 2802efa and 8 for PR HEAD 67025f3 in total

@openshift-ci openshift-ci bot merged commit 36d9845 into master Jun 13, 2022
@vrutkovs vrutkovs mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander Awaiting requested review from haircommander

@jlebon jlebon Awaiting requested review from jlebon

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LorbusChris @vrutkovs @haircommander @jlebon @openshift-bot @openshift-ci-robot