-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: Use cri-o module from Fedora #249
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5cbde26
to
76ab55c
Compare
It looks like cri-o is still at version 1.19 in both f34 and f35 modular repos. This can probably wait until we've rebased to f35, but it'd be great if we could start consuming cri-o from Fedora modular repos after that. |
We're already using upstream repos for crio, what's the benefit of waiting more time for it to be packaged as a module? |
I've got 1.21 and 1.22 in testing right now https://bodhi.fedoraproject.org/users/haircommander if folks wanna go and give it karma :) |
Indeed, that's up to OKD to decide. I can say at least that doing so aligns better with coreos/fedora-coreos-tracker#767. I think we should add CI coverage for the Fedora modules in FCOS and if OKD uses the modules too, then CI could test it by simply running OKD node tests too, which I think increase the value a lot. Of course, this is all also related to #210. |
/retest |
1 similar comment
/retest |
76ab55c
to
0aa7375
Compare
Build failure due to https://status.quay.io/incidents/rm3k6b5nby8m |
/retest |
2 similar comments
/retest |
/retest |
0aa7375
to
4f56db7
Compare
I am not sure why it takes so long, but I've finally seen 1.22 builds in bodhi for f34 https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2021-ee666025b5 once that makes it through, I think this will work? |
Ah yeah, thanks I forgot we're still on F34 🤦♂️ While you're at this, any plans to do 1.23 builds soon? 😇 |
I am actively trying to get the module build to work! since it requires go 1.17 there may be a delay while fedora get it. the dist-git seems to indicate it's on 1.16 but I saw an article saying it'll make f35 so idk) |
It looks like Go 1.17 has unfortunately been deferred to F36 :( |
/retest |
014aa65
to
8adf2a6
Compare
OK, the module seems to be available now, but there's a new problem:
@jlebon any idea? |
Hmm not sure offhand, I'd have to dig in and try to reproduce it on the roughly equivalent FCOS 34 version. Usually, this works by libdnf looking at the |
we'll have to wait with this until there's a cri-o 1.23(++) module is available, which won't be the case before F36 |
/remove-lifecycle stale |
@LorbusChris: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
bcd41d4
to
97ce794
Compare
I'm a bit concerned about fixes taking more time to land in Fedora (due to Bodhi), but I think we'll take it. However lets move "bump to F36" in a separate PR as its quite a big change |
/retest-required |
1 similar comment
/retest-required |
/retitle manifest: Use cri-o module from Fedora |
/test e2e-aws |
/test e2e-aws |
/retest |
1 similar comment
/retest |
/hold cancel |
@LorbusChris: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @vrutkovs
/cc @haircommander
/cc @jlebon