Skip to content
This repository has been archived by the owner on Dec 9, 2020. It is now read-only.

Fixes #893. Check if the target fs exists. #894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ioggstream
Copy link
Contributor

Running this role on a node which already has a device mounted on the
target mountpoint results in an error. This check makes the role
to understand that everything is fine.

What does this PR do?

Check if the target filesystem on the given device / mountpoint is present

How should this be manually tested?

Create the following playbook and run it twice.

cat > /tmp/test.yml <<EOF
---
- hosts: nodes
  roles:
  - openshift-volume-quota
EOF

ansible-playbook /tmp/test.yml

ansible-playbook /tmp/test.yml

Is there a relevant Issue open for this?

#893

Who would you like to review this?

cc: @tomassedovic PTAL

…int is present.

  Running this role on a node which already has a device mounted on the
    target mountpoint results in an error. This check makes the role
    to understand that everything is fine.
@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

2 similar comments
@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@pschiffe pschiffe added the common label Jan 2, 2018
@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@ioggstream
Copy link
Contributor Author

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
common lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants