Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "HACK: Disable false negatives for now" #2285

Closed
wants to merge 1 commit into from

Conversation

ehashman
Copy link
Contributor

@ehashman ehashman commented May 5, 2020

This reverts commit db88a2a.

False negatives are fixed in scap-security-guide-0.1.49-5.el7
See also https://bugzilla.redhat.com/show_bug.cgi?id=1823576

NONE

Fixes #2269.

Need to wait for the right version of the security guide to get published...

/hold

This reverts commit db88a2a.

False negatives are fixed in scap-security-guide-0.1.49-5.el7
See also https://bugzilla.redhat.com/show_bug.cgi?id=1823576
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #2285 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2285   +/-   ##
=======================================
  Coverage   41.65%   41.65%           
=======================================
  Files         305      305           
  Lines       23802    23802           
=======================================
  Hits         9915     9915           
  Misses      13307    13307           
  Partials      580      580           

@openshift-ci-robot
Copy link

@ehashman: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
e2e-create-20191027-private 8f6491c link /test e2e-create-20191027-private
upgrade-v18.0 8f6491c link /test upgrade-v18.0
upgrade-v20.0 8f6491c link /test upgrade-v20.0

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2021
@ehashman ehashman closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCAP checks failing after upstream changes
3 participants