RHDEVDOCS 5979 starting pipeline runs manually and on chatops, support OWNERS fully #75409
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Wed May 08 01:58:17 - Prow CI generated the docs preview: https://75409--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/about-pipelines-as-code.html |
|
lgtm |
| * The author is the owner of the repository. | ||
| * The author is a collaborator on the repository. | ||
| * The author is a public member on the organization of the repository. | ||
| * The comment author is listed in the `approvers` or `reviewers` section of the `OWNERS` file in the root of the repository, as defined in the https://www.kubernetes.dev/docs/guide/owners/[Kubernetes documentation]. {pac} supports the full specification for the `OWNERS` and `OWNERS_ALIASES` files. |
There was a problem hiding this comment.
Here where repeating that line below, I would put a note stating that "When the OWNERS file is using filters (https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#filters), approvers and reviewers are only matched against the ".*" filter.
| - approved | ||
| ... | ||
| ---- | ||
| * The pull request author is listed in the `approvers` or `reviewers` section of the `OWNERS` file in the root of the repository, as defined in the https://www.kubernetes.dev/docs/guide/owners/[Kubernetes documentation]. {pac} supports the full specification for the `OWNERS` and `OWNERS_ALIASES` files. |
There was a problem hiding this comment.
I don't think we support the full specification but only a subset, @enarha would know more about which ones.
There was a problem hiding this comment.
Yea, the same sentence repeats few times. I commented on the first instance (#75409 (comment)), but it applies here as well.
There was a problem hiding this comment.
@mramendi the update above is good, just apply it here as well.
openshift-ci
bot
added
lgtm
|
New changes are detected. LGTM label has been removed. |
|
Lgtm |
| [discrete] | ||
| .Matching a comment event to a pipeline run | ||
|
|
||
| You can use the following example to match the `pipeline-comment` pipeline run with a comment on a pull request, when the text of the comment matches the `^/merge-pr` regular expression: |
There was a problem hiding this comment.
@chmouel we also support on-comment for push as well right ?
There was a problem hiding this comment.
@savitaashture no still waiting this to be merged 🙃 openshift-pipelines/pipelines-as-code#1638 (would not make it for osp1.5 now as there is not enough time to dogfood this)
There was a problem hiding this comment.
Ah i see its still PR
thats what i remembered somewhere i saw the changes but was not able to recall that pull request 😆
|
/retest |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/remove-label peer-review-needed |
openshift-ci
bot
added
peer-review-in-progress
| * The author is the owner of the repository. | ||
| * The author is a collaborator on the repository. | ||
| * The author is a public member on the organization of the repository. | ||
| * The comment author is listed in the `approvers` or `reviewers` section of the `OWNERS` file in the root of the repository, as defined in the https://www.kubernetes.dev/docs/guide/owners/[Kubernetes documentation]. {pac} supports the specification for the `OWNERS` and `OWNERS_ALIASES` files. If the `OWNER` file includes a https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#filters[filters] section, {pac} matches approvers and reviewers only against the `.*` filter. |
There was a problem hiding this comment.
Typo: OWNER should be OWNERS
Same for both other times this text is used. 🙂
openshift-ci
bot
added
peer-review-done
| * Full references to branches such as `"refs/heads/main"` | ||
| * Globs with pattern matching such as `"refs/heads/\*"` | ||
| * Tags such as `"refs/tags/1.\*"` | ||
|
|
||
| [discrete] | ||
| .Matching a comment event to a pipeline run |
|
|
||
| To restart all or specific pipeline runs, use the following comments: | ||
|
|
||
| * The `/test` and `/retest` comment restarts all pipeline runs. | ||
|
|
||
| * The `/test <pipeline_run_name>` and `/retest <pipeline_run_name>` comment restarts a specific pipeline run. | ||
| * The `/test <pipeline_run_name>` and `/retest <pipeline_run_name>` comment starts or restarts a specific pipeline run. You can use this command to start any {pac} pipeline run on the repository, whether or not it was triggered by an event for this pipeline run. |
|
/retest |
|
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
sheriff-rh
added
merge-review-in-progress
Version(s):
pipelines-docs-main only
Issue:
RHDEVDOCS 5979
Link to docs preview:
https://75409--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/managing-pipeline-runs-pac.html (first two subsections)
QE review:
Additional information: