Skip to content

Update log6x-audit-log-filtering.adoc #93743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amandverma
Copy link

@amandverma amandverma commented May 26, 2025

Updated line 48 to 51, as inputRefs and filterRefs are accepting array type of value.

clf.spec.pipeline.inputRefs|outputRefs|filterRefs should of array type instead of string.

Version(s):

4.14 - 4.18

Issue:

https://issues.redhat.com/browse/OBSDOCS-970

Link to docs preview:

https://93743--ocpdocs-pr.netlify.app/
https://93743--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.1/log6x-clf-6.1.html
https://93743--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.2/log6x-clf-6.2.html

QE review:

  • QE has approved this change.

Additional information:

Updated line 48 to 51, as inputRefs and filterRefs are accepting array type of value.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2025
Copy link

openshift-ci bot commented May 26, 2025

@amandverma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amandverma
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 26, 2025
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 27, 2025
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress
/lgtm

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 27, 2025
@mletalie
Copy link
Contributor

Hello @amandverma,
Overall, looks good to me, but from what I can tell, your changes don't reflect the exact ask in the ticket, from what I can tell. I may be interpreting this incorrectly, but wanted to mention. Thanks.
image

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 27, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants