Skip to content

NO-ISSUE: [OTE] Refac: refac helper and olmv1 test to create namespace instead to use pre-existent #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camilamacedo86
Copy link
Contributor

The refactoring will be required for the other tests to use the helper
Also, it ensures that we create a namespace specific to the test instead of using a pre-existing one to ensure that tests are isolated.

@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

The refactoring will be required for the other tests to use the helper
Also, it ensures that we create a namespace specific to the test instead of using a pre-existing one to ensure that tests are isolated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2025
@openshift-ci openshift-ci bot requested review from anik120 and thetechnick August 8, 2025 22:29
Copy link
Contributor

openshift-ci bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 9, 2025

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn edb1eb2 link false /test okd-scos-e2e-aws-ovn
ci/prow/openshift-e2e-aws-techpreview edb1eb2 link false /test openshift-e2e-aws-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -2,25 +2,27 @@ package helpers

import (
"context"
"fmt"
"time"
Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuiwang02 @tmshort

This is an improvement:

  • I just want to ensure that the tests run in a new namespace — meaning they’re fully isolated.
  • I also refactored the helper so it’s easier to reuse in other tests. In many cases, we need to create the ClusterExtension and check that is installed. The code is centralised to facilitate. If you check the other open PRs that use this helper, I’ve already made sure they match the same version we have here.

Could you help me get this one merged? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants