-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45071: fix: adding an exclude list for pathological events occurring on SNO #29347
base: master
Are you sure you want to change the base?
Conversation
@jeff-roche: This pull request references Jira Issue OCPBUGS-45071, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jeff-roche The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@jeff-roche: This pull request references Jira Issue OCPBUGS-45071, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Job Failure Risk Analysis for sha: 3528906
|
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
Outdated
Show resolved
Hide resolved
3528906
to
545ab25
Compare
545ab25
to
678dab7
Compare
monitorapi.LocatorPodKey: regexp.MustCompile("catalogd-controller-manager"), | ||
}, | ||
jira: "https://issues.redhat.com/browse/OCPBUGS-45071", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have over corrected 😄 . Originally you were filtering events for [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers
. I don't think this does that anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path to testBackoffStartingFailedContainer is part of monitortests/node/legacynodemonitortests chain that starts with monitor Stop
But I believe you just moved the matchers under testframework/legacytestframeworkmonitortests. I don't think the filter gets applied to the code above (could be wrong)
@jeff-roche: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 678dab7
|
We are adding a list of exceptions for the pathological events that are failing the SNO blocking jobs. This is meant as a temporary band-aid until we have time to look into the underlying DNS issues causing these events.