Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45994: managed services: allow KubeDaemonSetMisScheduled alert #29357

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 10, 2024

OSD-26887: managed services taints several nodes as infrastructure. This taint appears to be applied after some of the platform DS are scheduled there, causing this alert to fire. Managed services rebalances the DS after the taint is added, and the alert clears, but origin fails this test. Allowing this alert to fire while we investigate why the taint is not added at node birth.

OSD-26887: managed services taints several nodes as infrastructure.
This taint appears to be applied after some of the platform DS are
scheduled there, causing this alert to fire.  Managed services
rebalances the DS after the taint is added, and the alert clears, but
origin fails this test. Allowing this alert to fire while we investigate
why the taint is not added at node birth.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 10, 2024
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-45994, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

OSD-26887: managed services taints several nodes as infrastructure. This taint appears to be applied after some of the platform DS are scheduled there, causing this alert to fire. Managed services rebalances the DS after the taint is added, and the alert clears, but origin fails this test. Allowing this alert to fire while we investigate why the taint is not added at node birth.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024

@stbenjam: This pull request references Jira Issue OCPBUGS-45994, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OSD-26887: managed services taints several nodes as infrastructure. This taint appears to be applied after some of the platform DS are scheduled there, causing this alert to fire. Managed services rebalances the DS after the taint is added, and the alert clears, but origin fails this test. Allowing this alert to fire while we investigate why the taint is not added at node birth.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jbpratt
Copy link
Contributor

jbpratt commented Dec 10, 2024

/lgtm

@openshift-ci openshift-ci bot requested review from rexagod and slashpai December 10, 2024 15:17
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@stbenjam
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@stbenjam: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 10, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8737ae6 and 2 for PR HEAD 6c10437 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d97e9ab and 1 for PR HEAD 6c10437 in total

@stbenjam
Copy link
Member Author

/skip
/override ci/prow/e2e-aws-ovn-microshift

@stbenjam
Copy link
Member Author

/override ci/prow/e2e-aws-ovn-microshift-serial

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-microshift

In response to this:

/skip
/override ci/prow/e2e-aws-ovn-microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-microshift-serial

In response to this:

/override ci/prow/e2e-aws-ovn-microshift-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member Author

/override ci/prow/e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3310db1 and 0 for PR HEAD 6c10437 in total

@openshift-ci-robot
Copy link

/hold

Revision 6c10437 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@stbenjam
Copy link
Member Author

/skip
/override ci/prow/e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-serial

In response to this:

/skip
/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6c10437 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-csi 6c10437 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 6c10437 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-cgroupsv2 6c10437 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-upgrade 6c10437 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-hypershift-conformance 6c10437 link false /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member Author

/hold cancel

Copy link

openshift-trt bot commented Dec 11, 2024

Job Failure Risk Analysis for sha: 6c10437

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones Medium
[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info
This test has passed 96.09% of 128 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
alert/KubeAPIErrorBudgetBurn should not be at or above info

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3310db1 and 2 for PR HEAD 6c10437 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e5c44d7 into openshift:master Dec 11, 2024
29 checks passed
@openshift-ci-robot
Copy link

@stbenjam: Jira Issue OCPBUGS-45994: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45994 has been moved to the MODIFIED state.

In response to this:

OSD-26887: managed services taints several nodes as infrastructure. This taint appears to be applied after some of the platform DS are scheduled there, causing this alert to fire. Managed services rebalances the DS after the taint is added, and the alert clears, but origin fails this test. Allowing this alert to fire while we investigate why the taint is not added at node birth.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@stbenjam: new pull request created: #29366

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202412120007.p0.ge5c44d7.assembly.stream.el9.
All builds following this will include this PR.

@stbenjam
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@stbenjam: new pull request could not be created: failed to create pull request against openshift/origin#release-4.18 from head openshift-cherrypick-robot:cherry-pick-29357-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-29357-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants