Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-47529: Add team members to the OWNERS file for PR approvals #29384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-47529: Add team members to the OWNERS file for PR approvals #29384

wants to merge 1 commit into from

Conversation

Moebasim
Copy link

@Moebasim Moebasim commented Dec 18, 2024 •
edited
Loading

This PR updates the OWNERS file to include two additional members who can approve pull requests.

@Moebasim Moebasim closed this Dec 18, 2024
@Moebasim Moebasim deleted the owners branch December 18, 2024 16:47
@Moebasim Moebasim reopened this Dec 18, 2024
@Moebasim
Copy link
Author

Moebasim commented Dec 19, 2024 •
edited
Loading

@adambkaplan @sayan-biswas I've just raised this PR for your review on the changes of both OWNERS files

@prabhapa
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@Moebasim Moebasim changed the title OWNERS file update NO_JIRA: OWNERS file update Dec 19, 2024
@Moebasim Moebasim changed the title NO_JIRA: OWNERS file update NO_JIRA_ISSUE: OWNERS file update Dec 19, 2024
@Moebasim Moebasim changed the title NO_JIRA_ISSUE: OWNERS file update NO-JIRA: OWNERS file update Dec 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2024
@openshift-ci-robot
Copy link

@Moebasim: This pull request explicitly references no jira issue.

In response to this:

OWNERS file update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

adambkaplan
adambkaplan reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Please squash commits and use a well-formatted commit message.

@Moebasim Moebasim changed the title NO-JIRA: OWNERS file update NO-JIRA: Add team members to the OWNERS file for PR approvals Dec 19, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@Moebasim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial d98b25e link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn-upgrade d98b25e link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn d98b25e link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-edge-zones d98b25e link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-hypershift-conformance d98b25e link false /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-single-node d98b25e link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade d98b25e link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-builds d98b25e link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-single-node-serial d98b25e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd d98b25e link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-openstack-ovn d98b25e link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Dec 20, 2024

Job Failure Risk Analysis for sha: d98b25e

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Low
[sig-network] pods should successfully create sandboxes by other
This test has passed 76.02% of 2389 runs on release 4.19 [Overall] in the last week.

@adambkaplan
Copy link
Contributor

I recommend creating an OCPBUGS JIRA for this. I have learned the hard way that you will want to backport this kind of OWNERS update, and following the process just makes your life a lot easier.

@Moebasim Moebasim changed the title NO-JIRA: Add team members to the OWNERS file for PR approvals OCPBUGS-47529: Add team members to the OWNERS file for PR approvals Dec 23, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 23, 2024
@openshift-ci-robot
Copy link

@Moebasim: This pull request references Jira Issue OCPBUGS-47529, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR updates the OWNERS file to include two additional members who can approve pull requests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prabhapa
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan, Moebasim, prabhapa, sayan-biswas
Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Moebasim
Copy link
Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan left review comments

@sayan-biswas sayan-biswas sayan-biswas approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@prabhapa prabhapa

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Moebasim @prabhapa @openshift-ci-robot @adambkaplan @sayan-biswas