-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPNET-582,OPNET-585: Add monitor test for on-prem keepalived #29387
base: master
Are you sure you want to change the base?
Conversation
@cybertron: This pull request references OPNET-582 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. This pull request references OPNET-585 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Looks like I'm still missing a piece to construct the timeline. |
/test e2e-metal-ipi |
@cybertron: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-metal-ipi-serial |
302cd62
to
094ed56
Compare
/test e2e-metal-ipi-ovn-dualstack |
We need to ensure that events occurring in the same second (which are fairly common in keepalived) are sorted such that the Took event happens before the Lost event. Otherwise we can end up with VIPs appearing to be places they actually weren't.
/test e2e-metal-ipi-ovn-dualstack |
/test e2e-vsphere Looks like this is now working well in the metal job. Just make sure it's working for the other on-prem platforms as well. |
/hold cancel Apparently the VSphere job in this repo is UPI so there was nothing to be tested, but it looks like it worked fine in OpenStack too so I think we're good to go. |
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This will provide a timeline of VIP moves while also verifying that the correct priority is present in the keepalived logs.