-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CNTRLPLANE-1485:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift #30307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-1485:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift #30307
Conversation
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance |
|
@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61cb0080-9ad9-11f0-880c-01ec80b2888e-0 |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5528069 to
9fb7603
Compare
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @LiangquanLi930 |
ec330d3 to
10c5a6d
Compare
…est on ARO and Baremetal Hypershift
|
/test go-verify-deps |
|
@wangke19: This PR has been marked as verified by |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance |
|
/verified by e2e tests |
|
@wangke19: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test unit |
|
/test e2e-aws-ovn-serial-2of2 |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: ed55852
New tests seen in this PR at sha: ed55852
|
|
/retest-required |
|
/test e2e-aws-ovn-microshift |
|
/test e2e-vsphere-ovn-upi |
|
/test e2e-aws-ovn-serial-2of2 |
|
/hold Revision ed55852 was retested 3 times: holding |
|
/test e2e-aws-ovn-microshift |
|
/unhold |
|
@wangke19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.20 |
|
@wangke19: new pull request created: #30439 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.19 |
|
@wangke19: new pull request created: #30440 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function
Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
The related test
[Jira: "kube-apiserver"] can collect apiserver.openshift.io/disruption-actor=poller poller pod logs expand_moreinvloved code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383 (something wrong with baremetal install on 4.20)