Skip to content

Conversation

@wangke19
Copy link
Contributor

@wangke19 wangke19 commented Sep 26, 2025

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
The related test [Jira: "kube-apiserver"] can collect apiserver.openshift.io/disruption-actor=poller poller pod logs expand_more invloved code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383 (something wrong with baremetal install on 4.20)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2025
@wangke19 wangke19 changed the title [WIP]fix(disruption): Skip internal LB monitor on Hypershift [WIP]CNTRLPLANE-1485:fix(disruption): Skip internal LB monitor on Hypershift Sep 26, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

The internal load balancer monitor is not applicable to Hypershift clusters and causes test failures. This change skips the deployment of the internal LB monitor on Hypershift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2025

@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61cb0080-9ad9-11f0-880c-01ec80b2888e-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 force-pushed the fix/hypershift-disruption-test branch from 5528069 to 9fb7603 Compare October 15, 2025 13:28
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
Code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
Code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
The related code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
The related code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383 (something wrong with baremetal install on 4.20)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function

Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
The related test [Jira: "kube-apiserver"] can collect apiserver.openshift.io/disruption-actor=poller poller pod logs expand_more invloved code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383 (something wrong with baremetal install on 4.20)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 changed the title [WIP]CNTRLPLANE-1485:fix(disruption): Skip internal LB monitor on Hypershift CNTRLPLANE-1485:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift Oct 15, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
@wangke19
Copy link
Contributor Author

/cc @LiangquanLi930

@openshift-ci openshift-ci bot requested a review from LiangquanLi930 October 15, 2025 14:11
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2025
@wangke19 wangke19 force-pushed the fix/hypershift-disruption-test branch from ec330d3 to 10c5a6d Compare October 16, 2025 04:36
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2025
@wangke19
Copy link
Contributor Author

/test go-verify-deps

@wangke19
Copy link
Contributor Author

/verified by e2e tests on AWS test , ARO test and Baremetal

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 23, 2025
@openshift-ci-robot
Copy link

@wangke19: This PR has been marked as verified by e2e tests on [AWS test](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30310-periodics-e2e-aws-ovn-conformance/1977613953450119168),[ARO test](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30310-periodics-e2e-azure-kubevirt-ovn/1977613994134867968) and [Baremetal](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30383-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance/1978394713446682624).

In response to this:

/verified by e2e tests on AWS test , ARO test and Baremetal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance

@wangke19
Copy link
Contributor Author

/verified by e2e tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 27, 2025
@openshift-ci-robot
Copy link

@wangke19: This PR has been marked as verified by e2e tests.

In response to this:

/verified by e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b60bbfe and 2 for PR HEAD ed55852 in total

@wangke19
Copy link
Contributor Author

/test unit

@wangke19
Copy link
Contributor Author

/test e2e-aws-ovn-serial-2of2

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f06eec0 and 1 for PR HEAD ed55852 in total

@openshift-trt
Copy link

openshift-trt bot commented Oct 29, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: ed55852

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[Jira:service-ca][sig-api-machinery] Service CA Operator should have a running operator and managed resources [Suite:openshift/service-ca-operator/conformance/parallel]" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[Jira:service-ca][sig-api-machinery] Service CA Operator should inject a CA bundle into an annotated configmap [Suite:openshift/service-ca-operator/conformance/parallel]" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: ed55852

  • "[Jira:service-ca][sig-api-machinery] Service CA Operator should have a running operator and managed resources [Suite:openshift/service-ca-operator/conformance/parallel]" [Total: 6, Pass: 6, Fail: 0, Flake: 0]
  • "[Jira:service-ca][sig-api-machinery] Service CA Operator should inject a CA bundle into an annotated configmap [Suite:openshift/service-ca-operator/conformance/parallel]" [Total: 6, Pass: 6, Fail: 0, Flake: 0]

@wangke19
Copy link
Contributor Author

/retest-required

@wangke19
Copy link
Contributor Author

/test e2e-aws-ovn-microshift

@wangke19
Copy link
Contributor Author

/test e2e-vsphere-ovn-upi

@wangke19
Copy link
Contributor Author

/test e2e-aws-ovn-serial-2of2

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8a4ef2a and 0 for PR HEAD ed55852 in total

@openshift-ci-robot
Copy link

/hold

Revision ed55852 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@wangke19
Copy link
Contributor Author

/test e2e-aws-ovn-microshift

@wangke19
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f886e4e and 2 for PR HEAD ed55852 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@wangke19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cgroupsv2 5528069 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node 5528069 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 5528069 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-edge-zones 5528069 link false /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a91d3d0 and 1 for PR HEAD ed55852 in total

@openshift-merge-bot openshift-merge-bot bot merged commit b46de17 into openshift:main Oct 29, 2025
20 checks passed
@wangke19 wangke19 deleted the fix/hypershift-disruption-test branch October 30, 2025 02:01
@wangke19
Copy link
Contributor Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@wangke19: new pull request created: #30439

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot

@wangke19: new pull request created: #30440

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants