STOR-2340: Add e2e tests for storage network policy #30359
Conversation
|
@mpatlasov @dobsonj Could you help take a look? |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 92d160d
New tests seen in this PR at sha: 92d160d
|
|
/test verify |
duanwei33
force-pushed
the
storage-networkpolicy-e2e
branch
from
1b1417c to
81e1f58
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 81e1f58
New tests seen in this PR at sha: 81e1f58
|
duanwei33
force-pushed
the
storage-networkpolicy-e2e
branch
from
a065245 to
c1d5777
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: c1d5777
|
duanwei33
force-pushed
the
storage-networkpolicy-e2e
branch
from
c1d5777 to
4580205
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 4580205
|
|
/retest |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: c514831
New tests seen in this PR at sha: c514831
|
duanwei33
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@duanwei33: This pull request references STOR-2340 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
duanwei33
force-pushed
the
storage-networkpolicy-e2e
branch
from
c514831 to
16c7f2c
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 16c7f2c
|
|
FYI, go-verify-deps started failing because PR#70376 was merged recently. |
|
Hi @duanwei33 , thank you for reworking test case "should ensure required NetworkPolicies exist with correct labels", it looks great! I have only a couple of nits remaining (see my inline comments). They are minor, I'm ok to lgtm anyway. Let me know if you're going to address them. Otherwise we can go ahead with current code as-is. Btw, how did you verify that |
|
/retest-required |
duanwei33
force-pushed
the
storage-networkpolicy-e2e
branch
from
16c7f2c to
55b9a04
Compare
This adds comprehensive e2e tests to verify that storage-related operators and controllers have the required network policy labels and that NetworkPolicy resources exist with correct pod selectors. Changes: - Add namespace constants to helpers.go for reuse across storage tests - Add storage_networkpolicy.go with tests for CSO and CSI operators - Verify required network policy labels on deployments - Validate NetworkPolicy resources in storage namespaces - Skip these tests on MicroShift clusters where they are not applicable - Temporarily disabled ManilaCSINamespace check due to OCPBUGS-61175
duanwei33
force-pushed
the
storage-networkpolicy-e2e
branch
from
55b9a04 to
da3860c
Compare
|
/lgtm |
|
/retest |
|
The The new tests added here are skipped on Microshift anyway, so this is just a pre-existing flake. This failure can be safely ignored. @dobsonj Could you help approve it? |
|
/approve |
openshift-ci-robot
added
the
verified
|
@dobsonj: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj, duanwei33, mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-ovn-microshift |
1 similar comment
|
/test e2e-aws-ovn-microshift |
|
/hold Revision da3860c was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
@duanwei33: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn-microshift |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: da3860c
|
openshift-merge-bot
bot
merged commit 1f66b70
into
openshift:main
|
/cherry-pick release-4.20 |
|
@duanwei33: new pull request created: #30441 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
This commit adds comprehensive e2e tests to verify that storage-related operators and controllers have the required network policy labels and that NetworkPolicy resources exist with correct pod selectors.
Changes:
Something on-tracking:
Test records: