NO-JIRA: oidc: ensure console and cli OIDC clients are available when enabling OIDC #30406
Conversation
… OIDC Signed-off-by: Bryce Palmer <[email protected]>
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure |
|
@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/41388ba0-aeaf-11f0-8d13-776c63461c71-0 |
Signed-off-by: Bryce Palmer <[email protected]>
|
/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure |
|
@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f44eef0-af6c-11f0-8b54-022f9bc74b2f-0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@everettraven: This PR was included in a payload test run from openshift/console-operator#1058
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/747dcae0-b03d-11f0-92c3-8601de7281c9-0 |
everettraven
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@everettraven: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @everettraven |
openshift-ci-robot
added
the
verified
|
@everettraven: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Revision 58ac6f2 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold Revision 58ac6f2 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@everettraven: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 58ac6f2
New tests seen in this PR at sha: 58ac6f2
|
3 participants
We found out that a fix for https://issues.redhat.com/browse/OCPBUGS-61432 that merged in the OpenShift Console led to a regression in the external OIDC behavior despite passing the existing suite of tests.
This is because we missed making sure that the status of both the OpenShift Console and OpenShift CLI clients are successfully reporting as
Availablewhen opting in to the External OIDC functionality.This PR updates the testing logic to ensure both of these clients are reporting that they are available to prevent a regression related to this in the future.