Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds tests for crosspulls #9731

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Adds tests for crosspulls #9731

merged 2 commits into from
Jul 8, 2016

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jul 7, 2016

@miminar @legionus ptal

@miminar I'll include your suggested chained cross pull when fixing #9730.

@soltysh soltysh mentioned this pull request Jul 7, 2016
Closed
@soltysh
Copy link
Contributor Author

soltysh commented Jul 7, 2016

[testextended][extended:core(builds)]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 66072ae

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/295/) (Extended Tests: core(builds))

@miminar
Copy link

miminar commented Jul 8, 2016

[test]
@soltysh does it impact extended:core(builds) in any way?

miminar
miminar reviewed Jul 8, 2016
View reviewed changes
test/end-to-end/core.sh
os::cmd::expect_success "docker pull ${DOCKER_REGISTRY}/cache/cross:repo-pull"
echo "[INFO] Cross repository pull successful"

imageid=$(docker images | grep cache/cross | awk '{ print $3 }')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd do the same.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 66072ae

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5945/)

@soltysh
Copy link
Contributor Author

soltysh commented Jul 8, 2016

@soltysh does it impact extended:core(builds) in any way?

It should not. This is just adding more tests for checking the crosspull problem #7792.

@soltysh
Copy link
Contributor Author

soltysh commented Jul 8, 2016

I forced extended tests, whereas hack/end-to-end/core.sh is run as part of the integration suite, which worked, awaiting sign-off in that case.

@miminar
Copy link

miminar commented Jul 8, 2016

LGTM, thanks!

@soltysh
Copy link
Contributor Author

soltysh commented Jul 8, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 8, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5947/) (Image: devenv-rhel7_4551)

@soltysh
Copy link
Contributor Author

soltysh commented Jul 8, 2016

#9490 flake

re-[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 66072ae

@miminar miminar mentioned this pull request Jul 8, 2016
Closed
@openshift-bot openshift-bot merged commit 1d2a238 into openshift:master Jul 8, 2016
@soltysh soltysh deleted the istag_pull branch July 11, 2016 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soltysh @openshift-bot @miminar