Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NVME-related UUID from images /usr/etc/nvme/hostid /usr/etc/nvme/hostnqn #1519

Open
travier opened this issue May 29, 2024 · 6 comments
Open

Remove NVME-related UUID from images /usr/etc/nvme/hostid /usr/etc/nvme/hostnqn #1519

travier opened this issue May 29, 2024 · 6 comments

Comments

@travier
Copy link
Member

travier commented May 29, 2024

See: #1445 (comment)

There are apparently hardcoded NMVE ids in the images right now and we should remove those to make sure those are unique and generated per-node.
@travier travier mentioned this issue May 29, 2024
Merged
@travier travier changed the title Remove NVMe-related UUID from images /usr/etc/nvme/hostid /usr/etc/nvme/hostnqn Remove NVME-related UUID from images /usr/etc/nvme/hostid /usr/etc/nvme/hostnqn May 29, 2024
travier added a commit to travier/os that referenced this issue May 29, 2024
@travier
manifests: Clean-up NVME-related IDs
b50f73d 
See: openshift#1519
@travier travier mentioned this issue May 29, 2024
Closed
@travier
Copy link
Member Author

travier commented Jun 5, 2024

See https://issues.redhat.com/browse/OCPBUGS-34629

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 4, 2024
Akrog added a commit to Akrog/cinder-operator that referenced this issue Sep 25, 2024
@Akrog
NVMe sample: Fix nvme ids
82a8c7e 
OpenShift image has the NVMe `hostid` and `hostnqn` hardcoded, so it
ends up being the same in all the control plane nodes, which is
problematic.

This `MachineConfig` fixes this issue by recreating both files when the
`hostid` doesn't match the system-uuid of the machine it is running on.

Bugs:
- https://issues.redhat.com/browse/OCPBUGS-34629
- openshift/os#1519
- openshift/os#1520
@Akrog Akrog mentioned this issue Sep 25, 2024
Merged
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2024
@jlebon
Copy link
Member

jlebon commented Oct 30, 2024

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 30, 2024
@dustymabe
Copy link
Member

In Fedora and EL10 the %post that generates this was removed:

I'm not sure if there are supporting changes made in nvme-cli and other packages that made this OK in EL10+.

I do know if I implement this change to rm -fv /etc/nvme/hostid /etc/nvme/hostnqn then the isci tests we have still work.

@dustymabe
Copy link
Member

I guess either way we don't want the same ID baked in so what we have right now is clearly wrong.

We can start with deleting them and then if we need to generate them on first boot for EL9 we can create a service to do that.

dustymabe pushed a commit to dustymabe/os that referenced this issue Jan 28, 2025
@travier @dustymabe
manifest-el9-shared: Clean-up NVME-related IDs
7a78eb9 
See openshift#1519
and https://issues.redhat.com/browse/OCPBUGS-34629
@dustymabe dustymabe mentioned this issue Jan 28, 2025
Closed
dustymabe pushed a commit to dustymabe/os that referenced this issue Jan 29, 2025
@travier @dustymabe
manifest-el9-shared: Clean-up NVME-related IDs
4ca04ef 
See openshift#1519
and https://issues.redhat.com/browse/OCPBUGS-34629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@openshift-bot @dustymabe @jlebon @travier