manifests: Clean-up NVME-related IDs

[travier]

See: #1519

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[travier]

This will likely need more testing and investigation but let's see if this breaks immediately or if we can invest in testing.

[openshift-ci]

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jlebon]

Didn't dig into this but two things offhand:

1. What e.g. scriptlet exactly creates these? Maybe there's a cleaner way to do this, including working with the package maintainers directly.
2. We need to ensure that the identifiers are correctly generated on first boot (or whenever they're necessary).

[travier]

100% agree.
/hold

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[travier]

/remove-lifecycle stale
/lifecycle frozen

[openshift-ci]

@travier: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/remove-lifecycle stale
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cgwalters]

• We should have a tracker bug against the package
• Workarounds like this ideally land in the bootc base image and are inherited from there

[jlebon]

• Workarounds like this ideally land in the bootc base image and are inherited from there

Yup, we're working up to that. Note nvme-cli isn't in tier-x, but the postprocess script would be harmless even if it doesn't exist.

(But again, this needs further investigation to make sure this is the right workaround.)