Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS-2608: Switch from c9s content to RHEL 9.4 beta content #1473

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

mike-nguyen
Copy link
Member

RHEL 9.4 customer beta is now publicly available.

RHEL 9.4 customer beta is now publicly available.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@mike-nguyen: This pull request references COS-2608 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

RHEL 9.4 customer beta is now publicly available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@marmijo
Copy link
Contributor

marmijo commented Mar 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04af9ec and 2 for PR HEAD 98a956c in total

@mike-nguyen
Copy link
Member Author

Need to check if the 9.4 beta content is mirrored in CI.

@mike-nguyen
Copy link
Member Author

Needs openshift/release#50316

Comment on lines -125 to -127
- repo: baseos
packages:
- kernel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for removing this part?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have it in https://github.com/openshift/os/blob/master/manifest-rhel-9.2.yaml and only in C9S and if I remember correctly we sometimes takes kernel in advance of RHEL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should be good.

@travier
Copy link
Member

travier commented Apr 2, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@travier
Copy link
Member

travier commented Apr 2, 2024

/lgtm

@mike-nguyen
Copy link
Member Author

/retest

1 similar comment
@mike-nguyen
Copy link
Member Author

/retest

4.16 is switching to 9.4 beta content. We should probably clean up
all references to 9.2 but lets keep the references until we get
closer to GA.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@marmijo
Copy link
Contributor

marmijo commented Apr 3, 2024

/lgtm

@mike-nguyen
Copy link
Member Author

/test scos-9-build-test-qemu

@mike-nguyen
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024
@marmijo
Copy link
Contributor

marmijo commented Apr 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marmijo, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [marmijo,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-nguyen
Copy link
Member Author

/test scos-9-build-test-qemu

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04af9ec and 2 for PR HEAD 2644efc in total

@mike-nguyen
Copy link
Member Author

Seeing

BdsDxe: loading Boot0001 "UEFI Misc Device" from PciRoot(0x0)/Pci(0x2,0x0)
BdsDxe: failed to load Boot0001 "UEFI Misc Device" from PciRoot(0x0)/Pci(0x2,0x0): Access Denied
BdsDxe: No bootable option or device was found.
BdsDxe: Press any key to enter the Boot Manager Menu.

Which looks related to:

I tried building scos on master (not on this PR) and it had the same failure.

@sdodson
Copy link
Member

sdodson commented Apr 4, 2024 via email

@mike-nguyen
Copy link
Member Author

/override ci/prow/scos-9-build-test-qemu

The secure boot tests for c9s should be snoozed or skipped based on issues mentioned above. Lets override the scos-9-qemu test and address it in a separate PR. This change does not touch anything scos related.

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

@mike-nguyen: Overrode contexts on behalf of mike-nguyen: ci/prow/scos-9-build-test-qemu

In response to this:

/override ci/prow/scos-9-build-test-qemu

The secure boot tests for c9s should be snoozed or skipped based on issues mentioned above. Lets override the scos-9-qemu test and address it in a separate PR. This change does not touch anything scos related.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8f8cb93 into openshift:master Apr 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants