-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COS-2508: docs: explain how to enable swap #1490
base: master
Are you sure you want to change the base?
Conversation
swap support is now beta2 in kubernetes (as 1.28) and should be stable in 1.30. Document how to enable the feature on OCP. Follow openshift#1479
@jbtrystram: This pull request references COS-2507 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jbtrystram: This pull request references COS-2508 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
It's tempting to add more in-depth docs here, but I would suggest not going too deep into that. That level of depth I think belongs better in the OCP docs. Otherwise we end up with competing docs that need to be maintained in parallel. We have the FAQ, but that's meant to be more shorter answers that ideally link to more comprehensive docs (OCP/RHEL/upstream). Specifically for this, e.g. we could reformulate it as a FAQ question like:
Once we have more in-depth docs in the official docs, we can link to that. |
100% agree. My idea was to have a draft so someone from the docs could take over. |
NAME ALGORITHM DISKSIZE DATA COMPR TOTAL STREAMS MOUNTPOINT | ||
/dev/zram0 lzo-rle 4G 4K 80B 12K 4 [SWAP] | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor : may be we can remove these extra lines at the eof?
The remaining content lgtm otherwise
Normally the docs team adds those and might already be working on it (cc @jldohmann). But yeah, definitely useful to have this written out even just here in PR form as something to start with for the official docs. |
LGTM overall. Agree with Jonathan. Let's make this proper OCP docs. |
@jldohmann was this added to the OCP docs ? I see a couple of PRs but nothing related to ZRAM swap |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
swap support is now beta2 in kubernetes (as 1.28) and should be stable in 1.30.
Document how to enable the feature on OCP.
Follow #1479