Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS-2822: port gcp-routes to nftables #1562

Merged
merged 2 commits into from
Aug 15, 2024

Commits on Aug 8, 2024

  1. Remove unnecessary gcp-routes rule

    gcp-routes had a rule "so that existing flows (with an entry in
    conntrack) continue to be balanced, even if the DNAT entry is
    removed". The only way this iptables rule would actually be needed is
    if (a) your masters have an iptables-based firewall (which they
    shouldn't, on OCP), and (b) the firewall is so aggressive that it even
    drops packets from established connections (which no firewall should
    do anyway).
    
    At any rate, even if the rule *was* necessary in some clusters, it
    won't work in future nftables-only versions of RHCOS anyway, because
    nftables doesn't let "accept" rules in one table override
    "drop"/"reject" rules in another table; if your firewall is broken and
    dropping packets that it shouldn't, you have to actually fix your
    firewall rules, not hack around them somewhere else.
    danwinship committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a5085f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Port gcp-routes to nftables

    IPTables is going away in RHEL 10 so everything needs to be done with nftables.
    
    https://issues.redhat.com/browse/OCPSTRAT-940
    danwinship committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    29c6c1c View commit details
    Browse the repository at this point in the history