Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] NO-JIRA: extensions/Dockerfile: bump builder to f40 #1586

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Aug 22, 2024

Backports #1585

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2024
@openshift-ci-robot
Copy link

@sdodson: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@aaradhak aaradhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2024
@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Aug 22, 2024
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against this, but #1583 will be backported this far back and it will set the builder as fedora:latest

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, marmijo, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marmijo
Copy link
Contributor

marmijo commented Aug 22, 2024

/retitle [release-4.12] NO-JIRA: extensions/Dockerfile: bump builder to f40

@openshift-ci openshift-ci bot changed the title NO-JIRA: extensions/Dockerfile: bump builder to f40 [release-4.12] NO-JIRA: extensions/Dockerfile: bump builder to f40 Aug 22, 2024
@sdodson
Copy link
Member Author

sdodson commented Aug 22, 2024

Yeah I just saw that but then figured this brings these branches inline with others and I think that'll at least make the eventual cherry-picks clean.

@sdodson sdodson added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 22, 2024
@marmijo
Copy link
Contributor

marmijo commented Aug 22, 2024

Works for me! I don't remember what the original reasoning was behind not backporting it this far sooner. I know we experienced an issue with fedora:38 content and this branch was working fine.

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

@sdodson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4b16081 into openshift:release-4.12 Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants