-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] NO-JIRA: extensions/Dockerfile: bump builder to f40 #1586
[release-4.12] NO-JIRA: extensions/Dockerfile: bump builder to f40 #1586
Conversation
@sdodson: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not against this, but #1583 will be backported this far back and it will set the builder as fedora:latest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaradhak, marmijo, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle [release-4.12] NO-JIRA: extensions/Dockerfile: bump builder to f40 |
Yeah I just saw that but then figured this brings these branches inline with others and I think that'll at least make the eventual cherry-picks clean. |
Works for me! I don't remember what the original reasoning was behind not backporting it this far sooner. I know we experienced an issue with |
@sdodson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4b16081
into
openshift:release-4.12
Backports #1585