Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2099811: manifest: bump to openvswitch2.16 #715

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Feb 14, 2022

We want to keep host OVS and container OVS synchronized as much
as possible, plus OVS 2.16 is the first release that can take
advantage of kernel features like per-cpu dispatch (if the kernel
has it).

@trozet

We want to keep host OVS and container OVS synchronized as much
as possible, plus OVS 2.16 is the first release that can take
advantage of kernel features like per-cpu dispatch (if the kernel
has it).

Signed-off-by: Dan Williams <[email protected]>
@miabbott
Copy link
Member

Seems like a fine change to me; are there any specific requirements on the host OS? i.e. kernel, etc?

@jlebon
Copy link
Member

jlebon commented Feb 14, 2022

Related: #498

Meanwhile, if you have a checklist somewhere for rebasing Open vSwitch in the SDN container, it might be good to add an item for bumping it here too.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to making this switch. Ooh: better: I'm open to shifting the switch.

@dcbw
Copy link
Contributor Author

dcbw commented Feb 15, 2022

Seems like a fine change to me; are there any specific requirements on the host OS? i.e. kernel, etc?

@miabbott no requirements on host OS; RHEL QE tests the versions of OVS that we ship in FDP against various versions of RHEL. If it shows up in FDP releases then we support it.

@dcbw
Copy link
Contributor Author

dcbw commented Feb 15, 2022

Meanwhile, if you have a checklist somewhere for rebasing Open vSwitch in the SDN container, it might be good to add an item for bumping it here too.

@jlebon no checklist other than (a) has it been through normal RHEL FDP QE? and (b) does it pass CI?

@dcbw
Copy link
Contributor Author

dcbw commented Feb 16, 2022

/retest

@miabbott
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, dcbw, jlebon, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,jlebon,miabbott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member

One thing I'll note here that's important: CI here isn't going to test this in any meaningful way, i.e. we aren't yet today launching a cluster from this build. Hopefully soon we will be though!

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member

I believe the CI failed due to #718 + openshift/release#26305, but I built and tested this locally with success.

/override ci/prow/build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu

In response to this:

I believe the CI failed due to #718 + openshift/release#26305, but I built and tested this locally with success.

/override ci/prow/build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0f80f79 into openshift:master Feb 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@dcbw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw dcbw changed the title manifest: bump to openvswitch2.16 Bug 2099811: manifest: bump to openvswitch2.16 Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@dcbw: All pull requests linked via external trackers have merged:

Bugzilla bug 2099811 has been moved to the MODIFIED state.

In response to this:

Bug 2099811: manifest: bump to openvswitch2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants