-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers/ocmprovider: remove ccs overwrite logic #1383
providers/ocmprovider: remove ccs overwrite logic #1383
Conversation
21bf99a
to
9831980
Compare
We can remove this whole logic. |
9831980
to
d7cb541
Compare
remove the ccs.overwrite setting and logic as it is no longer needed/used Signed-off-by: Brady Pratt <[email protected]>
Thanks for the note, updated to remove all the overwrite logic! FWIW I still do multiple ccs clusters (and rosa sts) in the same account, osdCcsAdmin is still a thing that I use 😸 |
It is something we can use for sure. |
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbpratt, MrSantamaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jbpratt: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
remove the ccs.overwrite setting and logic as it is no longer needed/used
Signed-off-by: Brady Pratt [email protected]