Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] test linters #2342

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[WIP] test linters #2342

wants to merge 6 commits into from

Conversation

ritmun
Copy link
Contributor

@ritmun ritmun commented Feb 15, 2024 •
edited
Loading

Discussion for linter enhancements for this repo

https://golangci-lint.run/usage/linters/

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ritmun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@ritmun ritmun force-pushed the linters branch 3 times, most recently from 215322a to bfa2201 Compare February 16, 2024 16:13
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

@ritmun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/code-quality-checks fbd8e3e link true /test code-quality-checks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MrSantamaria MrSantamaria removed the request for review from Gaikanomer9 September 30, 2024 21:36
@MrSantamaria
Copy link
Contributor

@ritmun what do we want to do with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSantamaria MrSantamaria Awaiting requested review from MrSantamaria

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritmun @MrSantamaria