[DNM] Pre merge testing server side apply; Unblock QE

[tssurya]

cc @asood-rh : this should unblock you.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tssurya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[asood-rh]

@tssurya This PR did not help. Looking at the code I believe the change is in rule of policy YAML specifically use of namespaceSelector.
Previously this YAML worked

  egress:
  - name: "deny-ns-test1"
    action: "Deny"
    to:
    - namespaces:
        namespaceSelector:
          matchLabels:
            kubernetes.io/metadata.name: test1

I modified the policy to have rule to see it work.

  ingress:
  - name: "default-allow-ns"
    action: "Allow"
    from:
    - namespaces:
          matchLabels:
            kubernetes.io/metadata.name: test1

Is getting rid of namespaceSelector intended change? What is the reason for change?

[tssurya]

@asood-rh : correct see commit3 511e583#diff-492a3f7092344236a03a5163bb32140d721866486dfb3bf62326153f1bf292de

See kubernetes-sigs/network-policy-api#196 for the why did we have to do this/reason.

So this PR actually helps bring us in parity with CNO. (it helps except you need to adjust the yamls)

Is getting rid of namespaceSelector intended change?: yes it is intended
did it work?

[tssurya]

@JoeAldinger : we also need to update our 4.16 docs to reflect the breaking API change compared to 4.15 and 4.14

[openshift-ci]

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway	2e86e24	link	false	/test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/gofmt	2944dc9	link	true	/test gofmt
ci/prow/okd-e2e-gcp-ovn	2944dc9	link	false	/test okd-e2e-gcp-ovn
ci/prow/security	2944dc9	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.