-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-wide: Support pending change to use stream metadata for CoreOS #16355
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On the plus side, it will be way easier now to reuse some of the jobs and infrastructure for FCOS directly, and we can also share tooling around downloading images that e.g. actually validates checksums/signatures and stuff. |
8ab0bbe
to
43228d4
Compare
ci-operator/step-registry/upi/conf/vsphere/ova/upi-conf-vsphere-ova-commands.sh
Outdated
Show resolved
Hide resolved
This is part of adapting RHCOS to use the same stream metadata JSON format that FCOS uses: openshift/os#477 This change specifically will pair with a pending change in: openshift/installer#4582 to embed CoreOS stream metadata in the installer git instead of the undocumented ad-hoc JSON format that ships there now.
43228d4
to
ad1b2cc
Compare
@cgwalters: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/uncc |
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is part of adapting RHCOS to use the same stream metadata JSON format
that FCOS uses:
openshift/os#477
This change specifically will pair with a pending change in:
openshift/installer#4582
to embed CoreOS stream metadata in the installer git instead
of the undocumented ad-hoc JSON format that ships there now.