Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: Support pending change to use stream metadata for CoreOS #16355

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

This is part of adapting RHCOS to use the same stream metadata JSON format
that FCOS uses:

openshift/os#477

This change specifically will pair with a pending change in:
openshift/installer#4582
to embed CoreOS stream metadata in the installer git instead
of the undocumented ad-hoc JSON format that ships there now.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cgwalters
To complete the pull request process, please assign staebler after the PR has been reviewed.
You can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

On the plus side, it will be way easier now to reuse some of the jobs and infrastructure for FCOS directly, and we can also share tooling around downloading images that e.g. actually validates checksums/signatures and stuff.

@cgwalters cgwalters force-pushed the rhcos-stream-metadata branch 2 times, most recently from 8ab0bbe to 43228d4 Compare March 1, 2021 19:53
This is part of adapting RHCOS to use the same stream metadata JSON format
that FCOS uses:

openshift/os#477

This change specifically will pair with a pending change in:
openshift/installer#4582
to embed CoreOS stream metadata in the installer git instead
of the undocumented ad-hoc JSON format that ships there now.
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

@cgwalters: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

/uncc

@openshift-ci openshift-ci bot removed the request for review from mtnbikenc September 7, 2021 18:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/e2e-aws-upi ad1b2cc link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-metal ad1b2cc link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi-xpn ad1b2cc link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack-upi ad1b2cc link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi ad1b2cc link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/release-4.5/e2e-vsphere ad1b2cc link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-azure-upi ad1b2cc link /test pj-rehearse
ci/prow/pj-rehearse ad1b2cc link /test pj-rehearse
ci/build-farm/arm01-dry ad1b2cc link /test arm01-dry
ci/build-farm/hive-dry ad1b2cc link /test hive-dry
ci/prow/openshift-image-mirror-mappings ad1b2cc link /test openshift-image-mirror-mappings
ci/prow/clusterimageset-updater ad1b2cc link /test clusterimageset-updater
ci/build-farm/build03-dry ad1b2cc link true /test build03-dry
ci/build-farm/build04-dry ad1b2cc link true /test build04-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2021
@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 11, 2022
@openshift-bot
Copy link
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants