aws-load-balancer: update ocp version #45653
Conversation
openshift-ci
bot
added
the
approved
|
/pj-rehearse |
|
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
|
openshift/aws-load-balancer-operator#120: to fix |
|
/pj-rehearse |
|
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-release-1.0-e2e-aws-operator |
1 similar comment
|
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-release-1.0-e2e-aws-operator |
|
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-release-1.0-e2e-aws-rosa-operator |
|
/retest |
|
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
| @@ -25,12 +25,12 @@ promotion: | |||
| releases: | |||
| initial: | |||
| integration: | |||
| name: "4.12" | |||
| name: "4.14" | |||
There was a problem hiding this comment.
Should this be 4.15 now? Just like #45662
alebedev87
force-pushed
the
albo-update-ocp-version
branch
from
d2f0adf
to
8d31a28
Compare
|
/pj-rehearse |
1 similar comment
|
/pj-rehearse |
|
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-operator |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
| @@ -1,6 +1,6 @@ | |||
| base_images: | |||
| base: | |||
| name: "4.12" | |||
| name: "4.14" | |||
There was a problem hiding this comment.
Right, let me fix it.
| @@ -79,6 +79,7 @@ tests: | |||
| OO_INSTALL_NAMESPACE: aws-load-balancer-operator | |||
| OO_PACKAGE: aws-load-balancer-operator | |||
| OO_TARGET_NAMESPACES: '!all' | |||
| OPENSHIFT_VERSION: "4.13" | |||
There was a problem hiding this comment.
This seems odd that you have OPENSHIFT_VERSION only on aws-load-balancer-operator-release-1.0.yaml. Is it needed? Why not the other files?
There was a problem hiding this comment.
Good question, I think I ignored the other branches since they are for the TechPreview releases.
There was a problem hiding this comment.
I figured this out. The TechPreview branch cannot have this because they don't have the rosa test back ported. And the 1.1 release was using 4.14 at the time the PR was created. Let me update 1.1 branch too.
There was a problem hiding this comment.
Yea that makes sense.
I suppose the point of this is to "pin" to a specific version of OpenShift in ROSA; without this, it looks like https://steps.ci.openshift.org/reference/rosa-cluster-provision installs the latest version of OCP with ROSA, which I believe we don't want.
Shouldn't we add this to ci-operator/config/openshift/aws-load-balancer-operator/openshift-aws-load-balancer-operator-main.yaml too?
There was a problem hiding this comment.
I suppose the point of this is to "pin" to a specific version of OpenShift in ROSA; without this, it looks like https://steps.ci.openshift.org/reference/rosa-cluster-provision installs the latest version of OCP with ROSA, which I believe we don't want.
Right
Shouldn't we add this to ci-operator/config/openshift/aws-load-balancer-operator/openshift-aws-load-balancer-operator-main.yaml too?
I think it's fine to keep the main branch as development one which runs on the latest OCP candidate available. This way we are sure we start new features on the latest OCP available on ROSA.
There was a problem hiding this comment.
Oh yea, that's a fair point. I think the tricky part is remembering to keep the OCP versioning up-to-date with our releases (hence the reason this PR was created).
There was a problem hiding this comment.
Yes. Similar problem we have in the operator repository with the latest doc links.
alebedev87
force-pushed
the
albo-update-ocp-version
branch
from
8d31a28
to
0fdfc38
Compare
alebedev87
force-pushed
the
albo-update-ocp-version
branch
from
0fdfc38
to
404d602
Compare
|
/pj-rehearse Re-rehearsing as new branches were impacted. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, gcs278 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update the versions of the OpenShift clusters on which the tests are run.