Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17897: Build and publish assisted-service-el8 image #52320

Merged
merged 2 commits into from
May 28, 2024

Conversation

carbonin
Copy link
Member

This image is required for assisted-service to be able to install clusters of version <4.16 in FIPS environments.

Resolves https://issues.redhat.com/browse/MGMT-17897

cc @adriengentil

Leaving as WIP until openshift/assisted-service#6347 is merged (adds the Dockerfile)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 21, 2024

@carbonin: This pull request references MGMT-17897 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

This image is required for assisted-service to be able to install clusters of version <4.16 in FIPS environments.

Resolves https://issues.redhat.com/browse/MGMT-17897

cc @adriengentil

Leaving as WIP until openshift/assisted-service#6347 is merged (adds the Dockerfile)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@openshift-ci openshift-ci bot requested review from adriengentil and rccrdpccl May 21, 2024 18:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@carbonin carbonin force-pushed the assisted-service-el8 branch from 51d101b to fa4dea8 Compare May 21, 2024 19:56
@@ -167,6 +173,15 @@ tests:
SOURCE_IMAGE_REF: assisted-service
test:
- ref: assisted-baremetal-images-publish
- as: mirror-nightly-image-el8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for a build after a commit is merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed the second job.

This image is required for assisted-service to be able to install
clusters of version <4.16 in FIPS environments.

Resolves https://issues.redhat.com/browse/MGMT-17897
@carbonin carbonin force-pushed the assisted-service-el8 branch from fa4dea8 to d5e3566 Compare May 22, 2024 14:19
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@carbonin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-service-master-edge-assisted-operator-catalog-publish-verify openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-ci-index openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-3masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-compact-day2-masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-compact-day2-workers openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-disconnected openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-hypershift-zero-nodes openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-multiarch-3masters-ocp openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-multiarch-sno-ocp openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-node-labels openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-workers openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-11 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-12 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-13 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-14 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-15 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-bond openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-bond-4-14 openshift/assisted-service presubmit Ci-operator config changed

A total of 84 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriengentil
Copy link
Contributor

/retest

@carbonin carbonin changed the title [WIP] MGMT-17897: Build and publish assisted-service-el8 image MGMT-17897: Build and publish assisted-service-el8 image May 28, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@carbonin
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@carbonin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 28, 2024
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1398c57 into openshift:master May 28, 2024
17 checks passed
@carbonin carbonin deleted the assisted-service-el8 branch May 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants