Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43499: Upgrade the control-plane flavor of shiftstack e2e-openstack-ovn-upgrade 4.16 from 4.15 periodic job #58831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MiguelCarpio
Copy link
Contributor

In an effort to solve the failed test [sig-etcd] etcd should not log excessive took too long messages due to a very unhealthy etcd cluster by infrastructure issues such as latency on network and/or disk.
This PR pretends to increase the control-plane resources setting the v1-standard-8 flavor (32GB RAM, 8 vCPUs) at e2e-openstack-ovn-upgrade 4.16 from 4.15 job which continuously fails by the etcd issue and only has passed the openshift-e2e-test once the control-plane flavor was upgraded like this run.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 14, 2024
@openshift-ci-robot
Copy link
Contributor

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-43499, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In an effort to solve the failed test [sig-etcd] etcd should not log excessive took too long messages due to a very unhealthy etcd cluster by infrastructure issues such as latency on network and/or disk.
This PR pretends to increase the control-plane resources setting the v1-standard-8 flavor (32GB RAM, 8 vCPUs) at e2e-openstack-ovn-upgrade 4.16 from 4.15 job which continuously fails by the etcd issue and only has passed the openshift-e2e-test once the control-plane flavor was upgraded like this run.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MiguelCarpio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@MiguelCarpio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-shiftstack-ci-release-4.16-upgrade-from-stable-4.15-e2e-openstack-ovn-upgrade N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@MiguelCarpio
Copy link
Contributor Author

/pj-rehearse periodic-ci-shiftstack-ci-release-4.16-upgrade-from-stable-4.15-e2e-openstack-ovn-upgrade

@openshift-ci-robot
Copy link
Contributor

@MiguelCarpio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@MiguelCarpio
Copy link
Contributor Author

/pj-rehearse periodic-ci-shiftstack-ci-release-4.16-upgrade-from-stable-4.15-e2e-openstack-ovn-upgrade

@openshift-ci-robot
Copy link
Contributor

@MiguelCarpio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@MiguelCarpio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MiguelCarpio
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@MiguelCarpio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 14, 2024
@EmilienM
Copy link
Member

This PR fixes one job, and I don't think this should be a snowflake. We should be consistent and do that for all the upgrade jobs.
Also, this has a strong impact on our quotas and the number of leases for that cloud. This is consuming more resources.

In the future, I believe this kind of job should be covered by QE who have more resource than us and we don't use public clouds for that (too expensive and we don't have enough quotas I believe).

cc @mandre @pierreprinetti

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants