Skip to content

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Sep 26, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from jcaamano and kyrtapz September 26, 2025 11:54
@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 26, 2025

@JoelSpeed adding the lanes you've requested in openshift/api#2496

@everettraven FYI

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 26, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 26, 2025

/pj-rehearse e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4 e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6 e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@maiqueb: job(s): e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4, e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6, e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview either don't exist or were not found to be affected, and cannot be rehearsed

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 26, 2025

/pj-rehearse periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4 periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qinqon
Copy link
Contributor

qinqon commented Sep 29, 2025

@maiqueb isn't the GA job need to be 4.20 instead of 4.21 ?

@maiqueb maiqueb force-pushed the ovn-kubernetes-add-virt-metal-virt-jobs-single-stack branch from ff403a0 to 491ad27 Compare September 29, 2025 09:05
@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 29, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the extra interface at nodes since we are not testing localnet at origin, let's remove it can cause connectivity issues since as part of it a extra default gw and dns server is configured, libvirt provide those as part of DHCP answer.

Comment on lines +94 to +96
EXTRA_NETWORK_CONFIG: |
EXTRA_NETWORK_NAMES="extranet"
EXTRANET_NETWORK_SUBNET_V4='192.168.221.0/24'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not testing localnet so we don't need any of those, let's remove it so we have less stuff going on at the udnerlay

Comment on lines +116 to +118
EXTRA_NETWORK_CONFIG: |
EXTRA_NETWORK_NAMES="extranet"
EXTRANET_NETWORK_SUBNET_V4='192.168.221.0/24'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines 158 to 160
EXTRA_NETWORK_CONFIG: |
EXTRA_NETWORK_NAMES="extranet"
EXTRANET_NETWORK_SUBNET_V6='fd2e:6f44:5dd8:ca56::/120'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto also the error that we have with installing openshift virt can be related to the fact that an extra default gw is being configured if we do this.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 29, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maiqueb maiqueb force-pushed the ovn-kubernetes-add-virt-metal-virt-jobs-single-stack branch from 96329d7 to b556de9 Compare September 30, 2025 11:20
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6 96329d7 link unknown /pj-rehearse periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6
ci/rehearse/periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview 96329d7 link unknown /pj-rehearse periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 30, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 30, 2025

@kyrtapz both rehearsals passed. We're all set for ipv4.

Could you review ?

FEATURE_SET: TechPreviewNoUpgrade
workflow: baremetalds-e2e-ovn-bgp-virt-dualstack
timeout: 6h0m0s
- as: e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4-techpreview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: I don't think we usually name the jobs single-stack as it is the default, same with ipv4.
What do you think about going with e2e-metal-ipi-ovn-bgp-virt-techpreview and e2e-metal-ipi-ovn-bgp-virt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused since this is the only comment I got, but is a nit. Should I do comply with this request or ignore it ?

I don't care that much about the name, and I'd rather do my little bit to save the rain forest a lil' bit by not requiring another CI round on this, but I'll blindly trust the maintainers judgement .

Copy link
Contributor

@kyrtapz kyrtapz Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just rename it please to keep it consistent.
We don't have to wait for another rehearsal.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 30, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 30, 2025
@maiqueb maiqueb force-pushed the ovn-kubernetes-add-virt-metal-virt-jobs-single-stack branch from b556de9 to 3752514 Compare September 30, 2025 17:14
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 30, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@maiqueb: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4 N/A periodic Periodic changed
periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 30, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 30, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6818896 into openshift:master Sep 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants