-
Notifications
You must be signed in to change notification settings - Fork 2k
ovnk, virt, periodics: add single stack IPv4/v6 jobs #69748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovnk, virt, periodics: add single stack IPv4/v6 jobs #69748
Conversation
@JoelSpeed adding the lanes you've requested in openshift/api#2496 @everettraven FYI |
/pj-rehearse |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4 e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6 e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@maiqueb: job(s): e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4, e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6, e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview either don't exist or were not found to be affected, and cannot be rehearsed |
/pj-rehearse periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6-techpreview periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4 periodic-ci-openshift-ovn-kubernetes-release-4.21-periodics-e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv6 |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@maiqueb isn't the GA job need to be 4.20 instead of 4.21 ? |
ff403a0
to
491ad27
Compare
/pj-rehearse |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the extra interface at nodes since we are not testing localnet at origin, let's remove it can cause connectivity issues since as part of it a extra default gw and dns server is configured, libvirt provide those as part of DHCP answer.
EXTRA_NETWORK_CONFIG: | | ||
EXTRA_NETWORK_NAMES="extranet" | ||
EXTRANET_NETWORK_SUBNET_V4='192.168.221.0/24' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not testing localnet so we don't need any of those, let's remove it so we have less stuff going on at the udnerlay
EXTRA_NETWORK_CONFIG: | | ||
EXTRA_NETWORK_NAMES="extranet" | ||
EXTRANET_NETWORK_SUBNET_V4='192.168.221.0/24' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
EXTRA_NETWORK_CONFIG: | | ||
EXTRA_NETWORK_NAMES="extranet" | ||
EXTRANET_NETWORK_SUBNET_V6='fd2e:6f44:5dd8:ca56::/120' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto also the error that we have with installing openshift virt can be related to the fact that an extra default gw is being configured if we do this.
/pj-rehearse |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
96329d7
to
b556de9
Compare
@maiqueb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/pj-rehearse |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@kyrtapz both rehearsals passed. We're all set for ipv4. Could you review ? |
FEATURE_SET: TechPreviewNoUpgrade | ||
workflow: baremetalds-e2e-ovn-bgp-virt-dualstack | ||
timeout: 6h0m0s | ||
- as: e2e-metal-ipi-ovn-bgp-virt-single-stack-ipv4-techpreview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: I don't think we usually name the jobs single-stack
as it is the default, same with ipv4.
What do you think about going with e2e-metal-ipi-ovn-bgp-virt-techpreview
and e2e-metal-ipi-ovn-bgp-virt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused since this is the only comment I got, but is a nit. Should I do comply with this request or ignore it ?
I don't care that much about the name, and I'd rather do my little bit to save the rain forest a lil' bit by not requiring another CI round on this, but I'll blindly trust the maintainers judgement .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just rename it please to keep it consistent.
We don't have to wait for another rehearsal.
/pj-rehearse ack |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Miguel Duarte Barroso <[email protected]>
… layered product Signed-off-by: Miguel Duarte Barroso <[email protected]>
b556de9
to
3752514
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
No description provided.