Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-12828 | fix: Do not print create policy commands more than once op roles #2660

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

hunterkepley
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 29.17%. Comparing base (ec3766d) to head (ea41336).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
cmd/create/operatorroles/by_prefix.go 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2660      +/-   ##
==========================================
- Coverage   29.18%   29.17%   -0.02%     
==========================================
  Files         184      184              
  Lines       25350    25359       +9     
==========================================
  Hits         7399     7399              
- Misses      17356    17365       +9     
  Partials      595      595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@den-rgb
Copy link
Contributor

den-rgb commented Dec 2, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: den-rgb, hunterkepley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [den-rgb,hunterkepley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@hunterkepley
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dcd493e into openshift:master Dec 2, 2024
11 checks passed
@hunterkepley
Copy link
Contributor Author

/cherry-pick release_1.2.49

@openshift-cherrypick-robot

@hunterkepley: #2660 failed to apply on top of branch "release_1.2.49":

Applying: OCM-12828 | fix: Do not print create policy commands more than once op roles
Using index info to reconstruct a base tree...
M	cmd/create/operatorroles/by_prefix.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/create/operatorroles/by_prefix.go
CONFLICT (content): Merge conflict in cmd/create/operatorroles/by_prefix.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCM-12828 | fix: Do not print create policy commands more than once op roles

In response to this:

/cherry-pick release_1.2.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants