Skip to content

Conversation

@pawelpros
Copy link
Contributor

Due to previous change (unifying naming for kata-tdx/kata-snp -> kata-cc runtimeclass) updated uninstall script

- Description of the problem which is fixed/What is the use case

Fixed removing runtimeclass which name was previously changed from kata-tdx/kata-snp to kata-cc

- How to verify it

  1. Perform install either with TEE: TDX or SNP
  2. Perform uninstall
  3. Expected behavior -> oc get runtimeclass will not show kata-cc name with handler: kata-tdx/kata-snp

- Description for the changelog

Updated uninstall script - fixed removing runtimeclass

@openshift-ci openshift-ci bot requested review from tbuskey and wainersm October 6, 2025 12:51
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

Hi @pawelpros. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawelpros pawelpros force-pushed the pproskur/fixremoveruntimeclass branch from 0d22b27 to 1714bdd Compare October 10, 2025 12:21
Due to previous change (unifying naming for kata-tdx/kata-snp -> kata-cc runtimeclass) updated uninstall script

Signed-off-by: Pawel Proskurnicki <[email protected]>
@pawelpros pawelpros force-pushed the pproskur/fixremoveruntimeclass branch from 1714bdd to 59ca787 Compare October 22, 2025 07:14
@pawelpros
Copy link
Contributor Author

@wainersm can we solve that - this is minor change which resolve bug which is already in the code ?

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

@pawelpros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bpradipt bpradipt merged commit 0761ba5 into openshift:devel Oct 23, 2025
4 of 5 checks passed
@pawelpros pawelpros deleted the pproskur/fixremoveruntimeclass branch October 23, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants