install-helper: Add ITA support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
fidencio
force-pushed
the
topic/install-helpers-add-ita-support
branch
3 times, most recently
from
b5e2aef to
2f580ca
Compare
fidencio
force-pushed
the
topic/install-helpers-add-ita-support
branch
from
2f580ca to
0cdb0e7
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
bpradipt
reviewed
Jan 10, 2025
Let's create ITA specific yamls, and allow the user to set ITA=true when calling the scripts, in order to get ITA easily installed. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/install-helpers-add-ita-support
branch
from
0cdb0e7 to
c11d5f5
Compare
|
/lgtm |
Not using ITA is also an option for Intel TDX machines, and when not using ITA we can rely on DCAP and the CoCo AS to deal with the attestation. For this case, the changes here is what's needed. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/install-helpers-add-ita-support
branch
from
c11d5f5 to
a83e8ff
Compare
|
New changes are detected. LGTM label has been removed. |
fidencio
force-pushed
the
topic/install-helpers-add-ita-support
branch
8 times, most recently
from
0aba515 to
a1df62f
Compare
fidencio
force-pushed
the
topic/install-helpers-add-ita-support
branch
2 times, most recently
from
f44eaba to
a83e8ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's create ITA specific yamls, and allow the user to set ITA=true when calling the scripts, in order to get ITA easily installed.
NOTE: I'm marking this as a draft so I can fully test it after coming back from vacation.