Fix OADP-5111: Backups partially fails when backing up all namespaces

[shubham-pampattiwar]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[openshift-ci-robot]

@shubham-pampattiwar: This pull request references OADP-5111 which is a valid jira issue.

In response to this:

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[kaovilai]

Related to #354

[kaovilai]

just noting that current warning code would not work for vmware-tanzu#8342 if it merges

[kaovilai]

This might work for vmware-tanzu#8342 a bit better.

backup.go/BackupWithResolvers

	if len(backupRequest.Spec.IncludedNamespaces) > 0 {
		nsManagedByArgoCD := getNamespacesManagedByArgoCD(kb.kbClient, backupRequest.NamespaceIncludesExcludes, log)

func getNamespacesManagedByArgoCD(kbClient kbclient.Client, includedNamespaces *collections.IncludesExcludes, log logrus.FieldLogger) []string {
	var nsManagedByArgoCD []string

	for _, nsName := range includedNamespaces.GetIncludes() {
	    ns := corev1api.Namespace{}
	    if err := kbClient.Get(context.Background(), kbclient.ObjectKey{Name: nsName}, &ns); err != nil {
		    // check for only those ns that exist and are included in backup
		    // here we ignore cases like "" or "*" specified under includedNamespaces
		    if apierrors.IsNotFound(err) {
			    continue
		    }
		    log.WithError(err).Errorf("error getting namespace %s", nsName)
		    continue
	    }
    
	    nsLabels := ns.GetLabels()
	    if len(nsLabels[ArgoCDManagedByNamespaceLabel]) > 0 {
		    nsManagedByArgoCD = append(nsManagedByArgoCD, nsName)
	    }
	}
	return nsManagedByArgoCD
}

[shubham-pampattiwar]

yeah we would need additional changes for covering namespacesIncludedByLabelSelector. Anyways current PR should be fine OADP 1.3.z

[kaovilai]

/lgtm

[openshift-ci]

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment