OCPBUGS-43273: fix panic when vcenter address is incorrect

[rhrmo]

When address of vcenter was set incorrectly, the code would throw runtime error, this PR fixes it.

cc @openshift/storage

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-43273, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When address of vcenter was set incorrectly, the code would throw runtime error, this PR fixes it.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhrmo]

/jira refresh

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-43273, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhrmo]

/hold

[rhrmo]

/unhold

[gnufied]

/retest

[gnufied]

/lgtm

[rhrmo]

/retest

[duanwei33]

I reproduced it by modifying the vcenter link in cm/cloud-provider-config, with the PR, there is no panic anymore although the storage CO is degraded due to connect issue, which is expected.
"vcenter not found" message from operator log and there is no panic:

W0206 13:20:14.814217       1 vspherecontroller.go:553] Marking cluster as degraded: openshift_api_error error creating new vsphere connection: vcenter not found
W0206 13:20:14.814242       1 vspherecontroller.go:609] Marking cluster un-upgradeable because error creating new vsphere connection: vcenter not found

And the storage CO reports the same:

storage                                    4.19.0-0.test-2025-02-06-094504-ci-ln-dymxiz2-latest   True        False         True       3h8m    VSphereCSIDriverOperatorCRDegraded: VMwareVSphereOperatorCheckDegraded: error creating new vsphere connection: vcenter not found

[duanwei33]

/label qe-approved

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-43273, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

When address of vcenter was set incorrectly, the code would throw runtime error, this PR fixes it.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhrmo]

/test e2e-vsphere-operator-test

[jsafrane]

@rhrmo you need to rebase :-(

[rhrmo]

@jsafrane thank you, I did not notice 😅

[openshift-ci]

@rhrmo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	d72cee9	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dobsonj]

/lgtm
/approve
/label acknowledge-critical-fixes

[openshift-ci]

@dobsonj: The label(s) /label acknowledge-critical-fixes cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/lgtm
/approve
/label acknowledge-critical-fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dobsonj]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@rhrmo: Jira Issue OCPBUGS-43273: All pull requests linked via external trackers have merged:

• openshift/vmware-vsphere-csi-driver-operator#283

Jira Issue OCPBUGS-43273 has been moved to the MODIFIED state.

In response to this:

When address of vcenter was set incorrectly, the code would throw runtime error, this PR fixes it.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhrmo]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@rhrmo: new pull request created: #292

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-vmware-vsphere-csi-driver-operator
This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.19.0-202502122141.p0.g13c887c.assembly.stream.el9.
All builds following this will include this PR.